InDetGeoModelUtils - Use GeoIntrusivePtr in favour of manual ref/unref

Replace ref & unref by the GeoIntrusivePtrs

added full-integration-tests full-unit-tests labels

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils

This merge request affects 6 files:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/GeoNodePtr.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/InDetMaterialManager.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/ServiceVolume.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/InDetMaterialManager.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/ServiceVolume.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/VolumeBuilder.cxx

Adding @goetz ,@sroe as watchers

added InnerDetector main review-pending-level-1 labels

CI Result FAILURE (hash 6984d386)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4370]

added 1 commit

• db7c1e50 - Revert mat manmager

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils

This merge request affects 4 files:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/GeoNodePtr.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/ServiceVolume.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/ServiceVolume.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/VolumeBuilder.cxx

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash db7c1e50)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4383]

marked this merge request as draft

removed review-pending-level-1 label

added 148 commits

• db7c1e50...8a9090be - 145 commits from branch atlas:main
• bfb34587 - Use GeoIntrusivePtr in favour of manual ref/unref
• 374c1e28 - Revert mat manmager
• c2d708c6 - Fix crash

Compare with previous version

added 1 commit

• 5563eada - Revert "Revert mat manmager"

Compare with previous version

marked this merge request as ready

changed the description

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils

This merge request affects 7 files:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/GeoNodePtr.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/InDetMaterialManager.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/ServiceVolume.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/VolumeBuilder.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/InDetMaterialManager.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/ServiceVolume.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/VolumeBuilder.cxx

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 5563eada)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4397]

removed review-pending-level-1 label

added review-user-action-required label

removed review-user-action-required label

marked this merge request as draft

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils

This merge request affects 7 files:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/GeoNodePtr.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/InDetMaterialManager.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/ServiceVolume.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/VolumeBuilder.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/InDetMaterialManager.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/ServiceVolume.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/VolumeBuilder.cxx

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash 5563eada)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4569]

marked this merge request as ready

added 235 commits

• 5563eada...a77044c5 - 234 commits from branch atlas:main
• 8a881b8d - Use GeoIntrusivePtr in favour of manual ref/unref

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils

This merge request affects 7 files:

• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/GeoNodePtr.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/InDetMaterialManager.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/ServiceVolume.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/InDetGeoModelUtils/VolumeBuilder.h
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/InDetMaterialManager.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/ServiceVolume.cxx
• InnerDetector/InDetDetDescr/InDetGeoModelUtils/src/VolumeBuilder.cxx

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 8a881b8d)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4696]

removed review-pending-level-1 label

MR looks good to me, approving.

Cheers, Yuriy (L1)

added review-approved label

merged

mentioned in commit e4fcf772