Skip to content
Snippets Groups Projects

Remove more legacy digitization configuration

Merged Remove more legacy digitization configuration
jchapman/athena:RemoveLegacyDigiConfig2_main into main
Merged John Derek Chapman requested to merge jchapman/athena:RemoveLegacyDigiConfig2_main into main

Calls to Digi_tf.pyand RDOMerge_tf.pywithout the --CAoption will fail.

This removes most legacy digitization configuration without overlapping with !66434 (merged).

Edited by John Derek Chapman

Merge request reports

Pipeline #6898352 failed

Stage: external

    Pipeline failed for dcf75fb8 on jchapman:RemoveLegacyDigiConfig2_main

    Merged by Tadej NovakTadej Novak 1 year ago (Feb 15, 2024 6:02am UTC)

    Merge details

    • Changes merged into main with 40e15c39 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • John Derek Chapman added full-unit-tests label

      added full-unit-tests label

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      Jenkins please retry a build

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 16 packages:

      • ForwardDetectors/AFP/AFP_Digitization
      • ForwardDetectors/ALFA/ALFA_Digitization
      • ForwardDetectors/LUCID/LUCID_Digitization
      • ForwardDetectors/ZDC/ZDC_SimuDigitization
      • InnerDetector/InDetDigitization/BCM_Digitization
      • InnerDetector/InDetDigitization/FastSiDigitization
      • InnerDetector/InDetDigitization/FastTRT_Digitization
      • InnerDetector/InDetDigitization/PixelDigitization
      • InnerDetector/InDetDigitization/SCT_Digitization
      • InnerDetector/InDetDigitization/TRT_Digitization
      • LArCalorimeter/LArDigitization
      • Simulation/Digitization
      • Simulation/G4Utilities/MCTruthSimAlgs
      • Simulation/SimuJobTransforms
      • Simulation/SimulationJobOptions
      • TileCalorimeter/TileSimAlgs

      Affected files list will not be printed in this case

      Adding @iouri ,@pavol ,@jchapman ,@solodkov ,@calfayan ,@stsuno ,@sroe ,@harkusha ,@lshan ,@battagl ,@cgrefe ,@goetz as watchers

    • ATLAS Robot added Digitization ForwardDetectors InnerDetector LAr Simulation Tile main labels

      added Digitization ForwardDetectors InnerDetector LAr Simulation Tile main labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :x: CI Result FAILURE

      Athena AthSimulation
      externals :white_check_mark: :white_check_mark:
      cmake :o: :white_check_mark:
      make N/A N/A
      tests N/A N/A

      :exclamation: Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4458]

    • John Derek Chapman added 1 commit

      added 1 commit

      • 62be451f - Remove legacy Digitization configuration

      Compare with previous version

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      Jenkins please retry a build

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 16 packages:

      • ForwardDetectors/AFP/AFP_Digitization
      • ForwardDetectors/ALFA/ALFA_Digitization
      • ForwardDetectors/LUCID/LUCID_Digitization
      • ForwardDetectors/ZDC/ZDC_SimuDigitization
      • InnerDetector/InDetDigitization/BCM_Digitization
      • InnerDetector/InDetDigitization/FastSiDigitization
      • InnerDetector/InDetDigitization/FastTRT_Digitization
      • InnerDetector/InDetDigitization/PixelDigitization
      • InnerDetector/InDetDigitization/SCT_Digitization
      • InnerDetector/InDetDigitization/TRT_Digitization
      • LArCalorimeter/LArDigitization
      • Simulation/Digitization
      • Simulation/G4Utilities/MCTruthSimAlgs
      • Simulation/SimuJobTransforms
      • Simulation/SimulationJobOptions
      • TileCalorimeter/TileSimAlgs

      Affected files list will not be printed in this case

      Adding @sroe ,@jchapman ,@battagl ,@solodkov ,@harkusha ,@iouri ,@goetz ,@lshan ,@pavol ,@stsuno ,@calfayan ,@cgrefe as watchers

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :x: CI Result FAILURE (hash 62be451f)

      Athena AthSimulation
      externals :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark:
      tests :o: :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4502]

    • John Derek Chapman added 1 commit

      added 1 commit

      • 7e78293d - Remove legacy Digitization configuration

      Compare with previous version

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      Digitization.DigitizationFlags still imported in TileInfoConfigurator.py and LArIdMap_MC_jobOptions.py. Adding back for now.

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      Jenkins please retry a build

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 16 packages:

      • ForwardDetectors/AFP/AFP_Digitization
      • ForwardDetectors/ALFA/ALFA_Digitization
      • ForwardDetectors/LUCID/LUCID_Digitization
      • ForwardDetectors/ZDC/ZDC_SimuDigitization
      • InnerDetector/InDetDigitization/BCM_Digitization
      • InnerDetector/InDetDigitization/FastSiDigitization
      • InnerDetector/InDetDigitization/FastTRT_Digitization
      • InnerDetector/InDetDigitization/PixelDigitization
      • InnerDetector/InDetDigitization/SCT_Digitization
      • InnerDetector/InDetDigitization/TRT_Digitization
      • LArCalorimeter/LArDigitization
      • Simulation/Digitization
      • Simulation/G4Utilities/MCTruthSimAlgs
      • Simulation/SimuJobTransforms
      • Simulation/SimulationJobOptions
      • TileCalorimeter/TileSimAlgs

      Affected files list will not be printed in this case

      Adding @goetz ,@lshan ,@battagl ,@solodkov ,@sroe ,@cgrefe ,@iouri ,@stsuno ,@jchapman ,@pavol ,@calfayan ,@harkusha as watchers

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :x: CI Result FAILURE (hash 7e78293d)

      Athena AthSimulation
      externals :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark:
      tests :o: :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4516]

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      OK, this one seems fine now except for the Presampling CI tests which are still legacy configuration.

    • John Derek Chapman
      John Derek Chapman @jchapman ·
      Author Owner

      Copying here to preserve the info after the CI logs disappear:
      Legacy config unit tests with dependencies on DigitizationFlags

      	107 - AthenaPoolTest_EventInfoWrite_ctest (Failed)
	108 - AthenaPoolTest_EventInfoWriteStep2_ctest (Failed)
	109 - AthenaPoolTest_EventInfoWriteStep3_ctest (Failed)
	110 - AthenaPoolTest_EventInfoWriteStep4_ctest (Failed)
	111 - AthenaPoolTest_EventInfoWriteStep5_ctest (Failed)
	112 - AthenaPoolTest_EventInfoRead_ctest (Failed)
	1276 - LArConditionsTest_LArConditionsTest_ctest (Failed)
	1277 - LArConditionsTest_LArConditionsTestWriteNoReg_ctest (Failed)
	1278 - LArConditionsTest_LArConditionsTestReadNoReg_ctest (Failed)
	1724 - ISF_Config_test_Sim_tf_configuration_ctest (Failed)
	1834 - TileRecUtils_TileCellBuilder_test_ctest (Failed)
	1835 - TileRecUtils_TileCellBuilderFromHit_test_ctest (Failed)
	1836 - TileRecUtils_TileRawChannelBuilder_test_ctest (Failed)
	1837 - TileRecUtils_TileDQstatusAlg_test_ctest (Failed)
	1838 - TileRecUtils_TileDQstatusTool_test_ctest (Failed)
    • Tadej Novak
      Tadej Novak @tadej ·
      Developer

      Jenkins please retry a build

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 16 packages:

      • ForwardDetectors/AFP/AFP_Digitization
      • ForwardDetectors/ALFA/ALFA_Digitization
      • ForwardDetectors/LUCID/LUCID_Digitization
      • ForwardDetectors/ZDC/ZDC_SimuDigitization
      • InnerDetector/InDetDigitization/BCM_Digitization
      • InnerDetector/InDetDigitization/FastSiDigitization
      • InnerDetector/InDetDigitization/FastTRT_Digitization
      • InnerDetector/InDetDigitization/PixelDigitization
      • InnerDetector/InDetDigitization/SCT_Digitization
      • InnerDetector/InDetDigitization/TRT_Digitization
      • LArCalorimeter/LArDigitization
      • Simulation/Digitization
      • Simulation/G4Utilities/MCTruthSimAlgs
      • Simulation/SimuJobTransforms
      • Simulation/SimulationJobOptions
      • TileCalorimeter/TileSimAlgs

      Affected files list will not be printed in this case

      Adding @calfayan ,@harkusha ,@battagl ,@stsuno ,@jchapman ,@cgrefe ,@solodkov ,@lshan ,@sroe ,@pavol ,@iouri ,@goetz as watchers

    • John Derek Chapman marked this merge request as ready

      marked this merge request as ready

    • John Derek Chapman added review-pending-level-1 label

      added review-pending-level-1 label

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply