Removal of legacy config for DAOD production - part 4

ATLASG-2592

This MR removes much of the legacy DAOD-making configuration code, such that the old-style reductionConf argument to Reco_tf will no longer work.

Some of the packages touched here may be completely obsolete and so more deletion may be possible, but for this MR the changes are restricted to DAOD building.

added Derivation main labels

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTop
• PhysicsAnalysis/PATJobTransforms
• Reconstruction/RecJobTransforms
• Tools/PyJobTransforms

Affected files list will not be printed in this case

Adding @bmondal ,@seggebre ,@tadej ,@emmat ,@jcatmore ,@ravinab ,@thsteven ,@goetz ,@krumnack ,@rlysak as watchers

added Analysis CPAlgorithms JetEtmiss Reconstruction Tools analysis-review-required review-pending-level-1 labels

This MR removes old configuration code of derivations, no impact on analysis code, so approving from aR side

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

CI Result SUCCESS (hash 3e7cc1aa)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4745]

added review-approved label

removed review-pending-level-1 label

removed review-approved label

added review-pending-level-1 label

Another warning...

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/RecJobTransforms/python/recTransformUtils.py:10:1: warning: F401 'PyJobTransforms.trfExe.reductionFrameworkExecutor' imported but unused
from PyJobTransforms.trfExe import athenaExecutor, dummyExecutor, DQMergeExecutor, reductionFrameworkExecutor, reductionFrameworkExecutorNTUP

added review-user-action-required label

removed review-pending-level-1 label

added 1 commit

• e982861e - Removing unused imports

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTop
• PhysicsAnalysis/PATJobTransforms
• Reconstruction/RecJobTransforms
• Tools/PyJobTransforms

Affected files list will not be printed in this case

Adding @thsteven ,@krumnack ,@bmondal ,@goetz ,@tadej ,@emmat ,@jcatmore ,@rlysak ,@ravinab ,@seggebre as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash e982861e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4773]

MR looks good to me, approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label