Fix global Jvt SF retrieval in JetJvtEfficiency

With the refactoring of the Jvt-related analysis tools in !64846 (merged), the "dummy value" of the Jvt SF for jets outside the validity range was changed from 1.0 to -1.0 This wasn't propagated to functionality of JetJvtEfficiency to return a Jvt SF for the whole event. This yields to negative total Jvt SFs in some events. Although the JetJvtEfficiency is legacy code and users should move to the CPalgs or the refactored set of Jvt tools, we decided to fix this for people still in the migration phase.

Tagging @robouque who proposed this as well as @gotero and @aoneill for MET/PU-tagging.

marked this merge request as ready

changed the description

marked this merge request as draft

added 1 commit

• 8ebe28dc - catch OutOfValidity codes in JetJvtEfficiency

Compare with previous version

marked this merge request as ready

Jenkins please retry a build

@miholzbo note that you need to explicitly request a build while undrafting

Best, Thomas - L2

This merge request affects 1 package:

• Reconstruction/Jet/JetJvtEfficiency

This merge request affects 1 file:

• Reconstruction/Jet/JetJvtEfficiency/Root/JetJvtEfficiency.cxx

Adding @goetz as watcher

added JetEtmiss Reconstruction analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 8ebe28dc)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4800]

Looks good to me. L1

added review-approved label and removed review-pending-level-1 label

Looks OK from AR viewpoint

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

mentioned in commit fab6ba8e

merged