Cleanup transform setup of legacy config + TAG format

This MR cleans up transform infrastructure in preparation for --CA being default:

• remove default skeleton
• cleanup references to legacy skeletons (main target of this MR)
• cleanup obsolete transform steps
• cleanup TAG format

/cc @jchapman @nstyles @jcatmore @fwinkl @jdandoy @christos @wlampl

added full-unit-tests label

Jenkins please retry a build

This merge request affects 10 packages:

• HLT/Trigger/TrigTransforms/TrigTransform
• PhysicsAnalysis/PATJobTransforms
• Reconstruction/RecJobTransforms
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/SimuJobTransforms
• Tools/FullChainTransforms
• Tools/PROCTools
• Tools/PyJobTransforms
• Tools/PyJobTransformsCore
• Tools/Tier0ChainTests

Affected files list will not be printed in this case

Adding @fwinkl ,@stelzer ,@mark ,@goetz ,@wiedenma ,@schaarsc ,@tadej ,@jchapman ,@jbeirer ,@fpastore ,@zhangr as watchers

added Analysis Reconstruction Simulation Tools Trigger main labels

WARNING: big files (>100K) are found in the changeset

128K in file Tools/PyJobTransforms/python/trfArgClasses.py

100K in file Tools/PyJobTransformsCore/python/trfutil.py

116K in file Tools/PyJobTransforms/python/trfExe.py

CI Result FAILURE (hash 8fec7f45)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4790]

Hi @tadej,

As you marked for RDOtoRDOTrigger, leaving the skeleton allows a user to use an old release. Are there no non-trigger cases (we will also use it potentially for BSRDOtoRAW in trigRecoExecutor) where we might use a transform from the latest release, but use the asetup argument to switch back to an older release?

If the cleanup is needed, why not go one step further and just replace the default from 'PyJobTransforms/skeleton.dummy.py' to 'None' in athenaExecutor

Cheers, Mark

Hi @tadej ,

Following the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf

If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in main, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.

Thanks!

James, John, Nick

changed the description

removed main label

changed target branch from main to 24.0

added 275 commits

• 8fec7f45...8187ed23 - 274 commits from branch atlas:24.0
• f85a3e30 - Cleanup transform setup of legacy config + TAG format

Compare with previous version

added full-integration-tests label

Jenkins please retry a build

This merge request affects 14 packages:

• Calorimeter/CaloLocalHadCalib
• HLT/Trigger/TrigTransforms/TrigTransform
• LArCalorimeter/LArCafJobs
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
• PhysicsAnalysis/PATJobTransforms
• Reconstruction/RecJobTransforms
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Overlay/OverlayConfiguration
• Simulation/SimuJobTransforms
• Tools/FullChainTransforms
• Tools/PROCTools
• Tools/PyJobTransforms
• Tools/PyJobTransformsCore
• Tools/Tier0ChainTests

Affected files list will not be printed in this case

Adding @jcatmore ,@tadej ,@fpastore ,@jbeirer ,@ahaas ,@zhangr ,@stelzer ,@tkharlam ,@emmat ,@pavol ,@jchapman ,@goetz ,@fwinkl ,@mark ,@schaarsc ,@wiedenma as watchers

added 24.0 Calorimeter Derivation LAr Overlay labels

WARNING: big files (>100K) are found in the changeset

124K in file Tools/PyJobTransforms/python/trfArgClasses.py

100K in file Tools/PyJobTransformsCore/python/trfutil.py

112K in file Tools/PyJobTransforms/python/trfExe.py

CI Result FAILURE (hash f85a3e30)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5187] (for remote access see the FAQ for MR reviewers)

added 40 commits

• f85a3e30...2e43a829 - 39 commits from branch atlas:24.0
• 3229463b - Cleanup transform setup of legacy config + TAG format

Compare with previous version