Skip to content
Snippets Groups Projects

Simplification in the MCTruthClassifier

Merged Simplification in the MCTruthClassifier
averbyts/athena:classifiers into main
All threads resolved!
Merged Andrii Verbytskyi requested to merge averbyts/athena:classifiers into main
All threads resolved!

Simplification in the MCTruthClassifier

@jchapman

Merge request reports

Pipeline #6923471 passed

Stage: external

    Pipeline passed for 3426f648 on averbyts:classifiers

    Approval is optional

    Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Feb 20, 2024 1:10pm UTC)

    Merge details

    • Changes merged into main with ad53a2aa (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/MCTruthClassifier

    This merge request affects 1 file:

    • PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx

    Adding @zmarshal as watcher

  • ATLAS Robot added Analysis analysis-review-required main review-pending-level-1 labels

    added Analysis analysis-review-required main review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena,AthGeneration,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 0f817dfd)

    Athena AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :o: :o:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :o: AthGeneration: number of compilation errors 1, warnings 0
    :o: AnalysisBase: number of compilation errors 1, warnings 3
    :o: AthAnalysis: number of compilation errors 1, warnings 3
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4894]

  • Andrii Verbytskyi added 1 commit

    added 1 commit

    • 3426f648 - Update MCTruthClassifierGen.cxx

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/MCTruthClassifier

    This merge request affects 1 file:

    • PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx

    Adding @zmarshal as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 3426f648)

    Athena AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4905]

  • Marco Rimoldi added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Yuriy Volkotrub
    Yuriy Volkotrub @yvolkotr ·
    Developer

    MR looks fine from L1 perspective, CI shows no problems.

    Hi @averbyts , can you close/resolve the thread? It will allow me to approve MR. Thanks.

    Cheers, Yuriy (L1)

    Edited by Yuriy Volkotrub
  • Andrii Verbytskyi resolved all threads

    resolved all threads

  • A
    Andrii Verbytskyi @averbyts ·
    Author Developer

    Hi @yvolkotr, done.

  • Yuriy Volkotrub removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Yuriy Volkotrub added review-approved label

    added review-approved label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit ad53a2aa

    mentioned in commit ad53a2aa

    • Please register or sign in to reply