Clean up legacy configs in DerivationFrameworkJetEtMiss + JetJvtEfficiency

Self-explanatory

added Derivation JetEtmiss full-unit-tests labels

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

This merge request affects 2 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss/python/JetCommon.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss/python/METCommon.py

Adding @nelsonc ,@jcatmore ,@jmellent ,@emmat ,@ispokhar ,@jveatch as watchers

added 24.0 review-pending-level-1 labels

Thanks for getting rid of these, @tstreble !

I'll ping also @cdelitzs and @wbalunas and @khoo and @bhodkins but I think we can go ahead with this finally

CI Result SUCCESS (hash 6cd3b53c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4927]

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

Hi @tstreble ,

Thanks a lot for preparing this :) Could I ask you for a favour? Could you please also remove the marked parts (basically everything starting from L37) from this file here:

https://gitlab.cern.ch/atlas/athena/-/blob/main/Reconstruction/Jet/JetJvtEfficiency/python/JetJvtEfficiencyToolConfig.py#L37-60

These are also leftovers from the legacy derivation configuration and I had it on the list to remove it once JetCommon disappears but given that you are doing it now, it might just be easier to not open a separate MR.

Thanks and cheers, Chris

added 1 commit

• 88a284ef - Remove legacy config in JetJvtEfficiencyToolConfig

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• Reconstruction/Jet/JetJvtEfficiency

Affected files list will not be printed in this case

Adding @ispokhar ,@emmat ,@jmellent ,@jveatch ,@jcatmore ,@goetz ,@nelsonc as watchers

added Reconstruction review-pending-level-1 labels and removed review-approved label

resolved all threads

changed title from Clean up legacy configs in DerivationFrameworkJetEtMiss to Clean up legacy configs in DerivationFrameworkJetEtMiss + JetJvtEfficiency

CI Result FAILURE (hash 88a284ef)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4977]

Unrelated failures

The following tests FAILED:
	1447 - MuonHitCsvDump_testCsvDumper_ctest (Failed)
	1449 - MuonGeoModelTestR4_testR4Geometry_ctest (Failed)
	1450 - MuonGeoModelTestR4_testR4SensitiveDetectors_ctest (Failed)

added review-approved label and removed review-pending-level-1 label

Code changes look good to me. With the test failures being unrelated i am approving this.

Cheers L1

added Legacy Config Removal review-approved-tier0 labels

mentioned in commit 1278c0c3