Updated handling of decorations in PhotonPointingTool
A.k.a why decorations should be written by algorithms and not by tools
Updated the handling of decorations added by the PhotonPointingTool to
- make their name actually configurable
- not recompute them in case they are already available
FYI @gfrattar @jburzyns (Note that this is targeting main as I assume this is what you will use for the vertex studies, since the corresponding developments would introduce some FT0-violation.)
Merge request reports
Activity
This merge request affects 1 package:
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
This merge request affects 2 files:
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection/PhotonVertexSelection/PhotonPointingTool.h
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection/Root/PhotonPointingTool.cxx
added Analysis Egamma analysis-review-required main review-pending-level-1 labels
CI Result FAILURE (hash 35675210)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5015]This merge request affects 1 package:
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
This merge request affects 2 files:
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection/PhotonVertexSelection/PhotonPointingTool.h
- PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection/Root/PhotonPointingTool.cxx
CI Result SUCCESS (hash 06c93310)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5021]removed review-pending-level-1 label
added review-approved label
added analysis-review-approved label and removed analysis-review-required label
mentioned in commit 06ade79e
mentioned in merge request !69130 (merged)
mentioned in commit 2fec3fd5