VP1: fix some missing signal/slot errors #2

Together with !69047 (merged), this closes ATLASVPONE-653

The problem this time was that connect was being called on signals and slots which weren't implemented. I started adding them, but then realised that the widgets were disabled in the interface. Since I didn't have easy access to QtCreator, at this point I gave up and just commented out the problematic lines.

I also made some changes to reduce the verbosity of VP1 - this can be added back by setting the VP1_DEBUG_OUTPUT env variable.

And for a bit of fun, I added a 3D ASCII art VP1 logo.

cc @rbianchi

This merge request affects 4 packages:

• graphics/VP1/VP1Algs
• graphics/VP1/VP1Base
• graphics/VP1/VP1Systems/VP1GeometrySystems
• graphics/VP1/VP1Systems/VP1GuideLineSystems

Affected files list will not be printed in this case

Adding @rbianchi as watcher

added 24.0 EventDisplay review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

108K in file graphics/VP1/VP1Systems/VP1GeometrySystems/src/VP1GeometrySystem.cxx

CI Result SUCCESS (hash 66aa473f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5055]

added review-user-action-required label and removed review-pending-level-1 label

This seems to have picked up conflicts. Could you have a look?

Cheers L1

added 98 commits

• 66aa473f...0bb9eb1f - 94 commits from branch atlas:24.0
• cd3719ed - Add logo text
• 2c673aa9 - Add missing people colour and transparency functions
• f997bdcc - Comment out unimplemented signals and slots, to remove warnings
• bf4032c5 - Reduce VP1s verbosity

Compare with previous version

This merge request affects 4 packages:

• graphics/VP1/VP1Algs
• graphics/VP1/VP1Base
• graphics/VP1/VP1Systems/VP1GeometrySystems
• graphics/VP1/VP1Systems/VP1GuideLineSystems

Affected files list will not be printed in this case

Adding @rbianchi as watcher

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

108K in file graphics/VP1/VP1Systems/VP1GeometrySystems/src/VP1GeometrySystem.cxx

CI Result SUCCESS (hash bf4032c5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5068]

added review-approved label and removed review-pending-level-1 label

Looks good to me for now. Approved.

Cheers L1

Hi @emoyse, thanks for the update.

Concerning the slots not being implemented, you're right; those were part of a work in progress that was not completed.

Thanks for commenting them, so we don't have extra clutter in the output. I will uncomment them as soon as I take some time to complete the work.

For the reviewer: Those commented lines should not be removed; they're WIP to be completed in a separate MR.

Best, --Ric.

resolved all threads

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit ac290495

merged

mentioned in merge request !69166 (merged)