Move more functions from MCTruthClassifier to TruthUtils

Move more functions from MCTruthClassifier to TruthUtils

@pclark @jchapman

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

added Analysis Generators analysis-review-required main review-pending-level-1 labels

CI integration tests for projects Athena,AthSimulation,AthGeneration,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash d65753a4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 7, warnings 108
AthSimulation: number of compilation errors 2, warnings 1
AthGeneration: number of compilation errors 3, warnings 4
AnalysisBase: number of compilation errors 4, warnings 23
AthAnalysis: number of compilation errors 4, warnings 24
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5063]

added review-user-action-required label and removed review-pending-level-1 label

There seem to be multiple compilation and one test failure. Could you have a look.

Cheers L1

added 1 commit

• 59cc5627 - Update HepMCHelpers.h

Compare with previous version

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI integration tests for projects Athena,AthGeneration,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 59cc5627)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 17
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 1, warnings 1
AnalysisBase: number of compilation errors 1, warnings 3
AthAnalysis: number of compilation errors 1, warnings 4
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5072]

added 1 commit

• fdcb3b65 - Update HepMCHelpers.h

Compare with previous version

added 13 commits

• fdcb3b65...2dc60f82 - 12 commits from branch atlas:main
• 5c2191d4 - Merge remote-tracking branch 'upstream/main' into 21022024a

Compare with previous version

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

added analysis-review-approved label and removed analysis-review-required label

added Run2-MCReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 5c2191d4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5084]

marked this merge request as draft

added 3 commits

• 5c2191d4...a9b1d007 - 2 commits from branch atlas:main
• b9dffc20 - Merge remote-tracking branch 'upstream/main' into 21022024a

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

removed review-pending-level-1 label

CI Result FAILURE (hash b9dffc20)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5110]

added 103 commits

• b9dffc20...665d2aaa - 102 commits from branch atlas:main
• 4e648b25 - Merge remote-tracking branch 'upstream/main' into 21022024a

Compare with previous version

Jenkins please retry the build

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

CI Result FAILURE (hash 4e648b25)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5136]

added 20 commits

• 4e648b25...e8f39764 - 18 commits from branch atlas:main
• 49feff8a - Merge remote-tracking branch 'upstream/main' into 21022024a
• 2df7290d - Merge branch '21022024a' of ssh://gitlab.cern.ch:7999/averbyts/athena into 21022024a

Compare with previous version

added 1 commit

• 1d6932d9 - OK

Compare with previous version

Jenkins please retry the build

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

CI Result FAILURE (hash 1d6932d9)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [[CI-MERGE-REQUEST-EL9 5159]](https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-EL9/5159/ (for remote access see the FAQ for MR reviewers)

added 225 commits

• 1d6932d9...d7909617 - 224 commits from branch atlas:main
• 30163eb5 - Merge branch athena:main into 21022024a

Compare with previous version

added 31 commits

• 30163eb5...93c874b8 - 30 commits from branch atlas:main
• 6c6f90e7 - Merge branch athena:main into 21022024a

Compare with previous version

added 367 commits

• 6c6f90e7...c61daa03 - 366 commits from branch atlas:main
• 6415ce7a - Merge branch athena:main into 21022024a

Compare with previous version

Jenkins please retry the build

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

CI Result FAILURE (hash 6415ce7a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5736] (remote access info)

added 89 commits

• 6415ce7a...953e407c - 88 commits from branch atlas:main
• 8e8c64f4 - Merge branch athena:main into 21022024a

Compare with previous version

added 74 commits

• 8e8c64f4...b9a6001c - 73 commits from branch atlas:main
• 44b93d39 - Merge branch 'main' into '21022024a'

Compare with previous version

added 282 commits

• 44b93d39...23fb305f - 281 commits from branch atlas:main
• 34adb6ac - Merge branch athena:main into 21022024a

Compare with previous version

removed Run2-MCReco-output-changed label

removed Run3-MCReco-output-changed label

marked this merge request as ready

Jenkins please retry the build

This merge request affects 2 packages:

• Generators/TruthUtils
• PhysicsAnalysis/MCTruthClassifier

Affected files list will not be printed in this case

Adding @zmarshal as watcher

added review-pending-level-1 label

added Run2-MCReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 34adb6ac)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6201] (remote access info)

@averbyts, are the output changes expected?

ERROR: Found the following errors in RecoRun2MC.log:
ERROR    Py:diff-root         INFO  [CombinedMuonTrackParticlesAuxDyn.truthOrigin]: 9 leaves differ
ERROR    Py:diff-root         INFO  [CombinedMuonTrackParticlesAuxDyn.truthType]: 9 leaves differ
ERROR    Py:diff-root         INFO  [CombinedMuonsLRTTrackParticlesAuxDyn.truthOrigin]: 2 leaves differ
ERROR    Py:diff-root         INFO  [CombinedMuonsLRTTrackParticlesAuxDyn.truthType]: 2 leaves differ
ERROR    Py:diff-root         INFO  [CombinedStauTrackParticlesAuxDyn.truthOrigin]: 1 leaves differ
ERROR    Py:diff-root         INFO  [CombinedStauTrackParticlesAuxDyn.truthType]: 1 leaves differ
ERROR    Py:diff-root         INFO  [ElectronsAuxDyn.truthOrigin]: 9 leaves differ
ERROR    Py:diff-root         INFO  [ElectronsAuxDyn.truthType]: 9 leaves differ
ERROR    Py:diff-root         INFO  [ExtraPolatedMuonsLRTTrackParticlesAuxDyn.truthOrigin]: 4 leaves differ
ERROR    Py:diff-root         INFO  [ExtraPolatedMuonsLRTTrackParticlesAuxDyn.truthType]: 4 leaves differ
ERROR    Py:diff-root         INFO  [ExtrapolatedMuonTrackParticlesAuxDyn.truthOrigin]: 9 leaves differ
ERROR    Py:diff-root         INFO  [ExtrapolatedMuonTrackParticlesAuxDyn.truthType]: 9 leaves differ
ERROR    Py:diff-root         INFO  [ForwardElectronsAuxDyn.truthOrigin]: 8 leaves differ
ERROR    Py:diff-root         INFO  [ForwardElectronsAuxDyn.truthType]: 8 leaves differ
ERROR    Py:diff-root         INFO  [GSFTrackParticlesAuxDyn.truthOrigin]: 19 leaves differ
ERROR    Py:diff-root         INFO  [GSFTrackParticlesAuxDyn.truthType]: 19 leaves differ
ERROR    Py:diff-root         INFO  [InDetLargeD0TrackParticlesAuxDyn.truthOrigin]: 16 leaves differ
ERROR    Py:diff-root         INFO  [InDetLargeD0TrackParticlesAuxDyn.truthType]: 16 leaves differ
ERROR    Py:diff-root         INFO  [InDetTrackParticlesAuxDyn.truthOrigin]: 25 leaves differ
ERROR    Py:diff-root         INFO  [InDetTrackParticlesAuxDyn.truthType]: 25 leaves differ
ERROR    Py:diff-root         INFO  [LRTElectronsAuxDyn.truthOrigin]: 9 leaves differ
ERROR    Py:diff-root         INFO  [LRTElectronsAuxDyn.truthType]: 9 leaves differ
ERROR    Py:diff-root         INFO  [LRTGSFTrackParticlesAuxDyn.truthOrigin]: 10 leaves differ
ERROR    Py:diff-root         INFO  [LRTGSFTrackParticlesAuxDyn.truthType]: 10 leaves differ
ERROR    Py:diff-root         INFO  [MSOnlyExtraPolatedMuonsLRTTrackParticlesAuxDyn.truthOrigin]: 2 leaves differ
ERROR    Py:diff-root         INFO  [MSOnlyExtraPolatedMuonsLRTTrackParticlesAuxDyn.truthType]: 2 leaves differ
ERROR    Py:diff-root         INFO  [MSOnlyExtrapolatedMuonTrackParticlesAuxDyn.truthOrigin]: 9 leaves differ
ERROR    Py:diff-root         INFO  [MSOnlyExtrapolatedMuonTrackParticlesAuxDyn.truthType]: 9 leaves differ
ERROR    Py:diff-root         INFO  [MuonSpectrometerTrackParticlesAuxDyn.truthOrigin]: 10 leaves differ
ERROR    Py:diff-root         INFO  [MuonSpectrometerTrackParticlesAuxDyn.truthType]: 10 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthParticlesAuxDyn.truthOrigin]: 17 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthParticlesAuxDyn.truthType]: 17 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.chamberIndex]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.chiSquared]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.etaIndex]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.nPhiLayers]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.nPrecisionHits]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.nTrigEtaLayers]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.numberDoF]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.px]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.py]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.pz]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.sector]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.t0]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.t0error]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.technology]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.x]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.y]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonTruthSegmentsAux.z]: 1 leaves differ
ERROR    Py:diff-root         INFO  [MuonsAuxDyn.truthOrigin]: 10 leaves differ
ERROR    Py:diff-root         INFO  [MuonsAuxDyn.truthType]: 10 leaves differ
ERROR    Py:diff-root         INFO  [MuonsLRTAuxDyn.truthOrigin]: 2 leaves differ
ERROR    Py:diff-root         INFO  [MuonsLRTAuxDyn.truthType]: 2 leaves differ
ERROR    Py:diff-root         INFO  [PhotonsAuxDyn.truthOrigin]: 22 leaves differ
ERROR    Py:diff-root         INFO  [PhotonsAuxDyn.truthType]: 22 leaves differ
ERROR    Py:diff-root         INFO  [StausAuxDyn.truthOrigin]: 1 leaves differ
ERROR    Py:diff-root         INFO  [StausAuxDyn.truthType]: 1 leaves differ

L1 shifter