AthenaConfiguration: remove global ConfigFlags instance

Remove the global ConfigFlags instance and the safe-guards to delete the instance manually from the various skeletons and drivers.

There are still quite a few references to import ConfigFlags in our repository. But likely these are all unused legacy job options.

Requires: !69145 (merged) !69129 (merged) !69173 (merged)

cc @tadej

added full-unit-tests label

Jenkins please retry a build

This merge request affects 10 packages:

• Control/AthenaConfiguration
• Generators/EvgenJobTransforms
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
• Reconstruction/RecJobTransforms
• Simulation/Overlay/OverlayConfiguration
• Simulation/SimuJobTransforms
• Tools/FullChainTransforms
• Tools/PyJobTransforms
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@martindl ,@ssnyder ,@jcatmore ,@tkharlam ,@ahaas ,@maszyman ,@jchapman ,@fpastore ,@goetz ,@tadej ,@lidiaz ,@gemmeren ,@emmat ,@fwinkl as watchers

added 24.0 Core Derivation Generators Overlay Reconstruction Simulation Tools Trigger TriggerMenu labels

changed the description

CI Result FAILURE (hash 4a850b2b)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5074]

The following tests FAILED:
	 99 - AthenaPoolTest_LArCellContWriter_ctest (Failed)
	100 - AthenaPoolTest_LArCellContRead_ctest (Failed)
	350 - AthenaConfiguration_OldFlags2NewFlagsTest_ctest (Failed)
	825 - EventBookkeeperTools_CutFlowSvcOutputMPStandardIO_ctest (Failed)
	826 - EventBookkeeperTools_CutFlowSvcOutputMPSharedWriter_ctest (Failed)
	827 - EventBookkeeperTools_CutFlowSvcOutputMPSharedWriterAlt_ctest (Failed)
	1273 - LArConditionsTest_LArConditionsTest_ctest (Failed)
	1274 - LArConditionsTest_LArConditionsTestWriteNoReg_ctest (Failed)
	1275 - LArConditionsTest_LArConditionsTestReadNoReg_ctest (Failed)

changed the description

changed the description

added Legacy Config Removal label

added 209 commits

• 4a850b2b...72bc368e - 208 commits from branch atlas:24.0
• 487cda3c - AthenaConfiguration: remove global ConfigFlags instance

Compare with previous version

changed the description

marked this merge request as ready

Jenkins please retry a build

This merge request affects 10 packages:

• Control/AthenaConfiguration
• Generators/EvgenJobTransforms
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
• Reconstruction/RecJobTransforms
• Simulation/Overlay/OverlayConfiguration
• Simulation/SimuJobTransforms
• Tools/FullChainTransforms
• Tools/PyJobTransforms
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @jchapman ,@ssnyder ,@martindl ,@jcatmore ,@tadej ,@ahaas ,@sutt ,@lidiaz ,@gemmeren ,@emmat ,@fpastore ,@goetz ,@tkharlam ,@maszyman ,@fwinkl as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 487cda3c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5423] (remote access info)

Unrelated (transient) failure in the DQ defects DB (I reran the test locally and it succeeded):

======================================================================
FAIL: Checking that virtual flags don't depend on non-existent flags
----------------------------------------------------------------------
Traceback (most recent call last):
File "/cvmfs/sft.cern.ch/lcg/releases/LCG_104d_ATLAS_1/nose/1.3.7/x86_64-el9-gcc13-opt/lib/python3.9/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/build2/ci-builds/24.0/Athena/build/Athena/x86_64-el9-gcc13-opt/python/DQDefects/tests/__init__.py", line 780, in test_virtual_defect_consistency
DefectsDB()._virtual_defect_consistency_check()
File "/build2/ci-builds/24.0/Athena/build/Athena/x86_64-el9-gcc13-opt/python/DQDefects/virtual_mixin.py", line 289, in _virtual_defect_consistency_check
assert not missing_defects, ("The following defects are used but not "
AssertionError: The following defects are used but not defined anywhere: {'AFP_TTC_RESTART', 'AFP_C_TOF_NOT_OPERATIONAL_TDAQ', 'AFP_STOPLESSLY_REMOVED', 'AFP_A_TOF_NOT_OPERATIONAL_TDAQ'}
-------------------- >> begin captured logging << --------------------
DQDefects.folders: DEBUG: Loading defects folder
DQUtils.db: INFO: Querying /GLOBAL/DETSTATUS/DEFECTLOGIC
DQUtils.db: DEBUG: Query range: [0, 9223372036854775807]
DQDefects.virtual_defect_mixin: ERROR: -- The missing defects are used by the following virtual defects
DQDefects.virtual_defect_mixin: ERROR: <missing> : <used by>
DQDefects.virtual_defect_mixin: ERROR: AFP_TTC_RESTART:AFP_TOF, AFP_SIT_A
DQDefects.virtual_defect_mixin: ERROR: AFP_C_TOF_NOT_OPERATIONAL_TDAQ:AFP_TOF
DQDefects.virtual_defect_mixin: ERROR: AFP_STOPLESSLY_REMOVED:AFP_TOF, AFP_SIT_A
DQDefects.virtual_defect_mixin: ERROR: AFP_A_TOF_NOT_OPERATIONAL_TDAQ:AFP_TOF
--------------------- >> end captured logging << ---------------------

Approving for now as CI failure unrelated. L1

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit def5f299

merged

mentioned in merge request !69320 (merged)