ComponentAccumulator: fix naming of public tools

Do not permanently rename public tools but use the namePrefix feature of gatherProps. This avoids that if a public tool is re-used in multiple places (and depending on the order of property serialization) that the tool name is set to "ToolSvc.MyTool" in the ToolHandle property.

I am slightly surprised that this didn't cause any problems so far.

Fixes ATR-28846. cc @tbold @wlampl

added full-unit-tests label

added bugfix label

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/ComponentAccumulator.py

Adding @maszyman ,@gemmeren ,@ssnyder as watchers

added 24.0 Core review-pending-level-1 labels

Tagging @jchapman as I think this did cause some issue in simulation and we worked around it.

CI Result SUCCESS (hash 2d81eb9d)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5121]

Looks good to me. L1

added review-approved label and removed review-pending-level-1 label

resolved all threads

added review-approved-point1 label

added review-approved-tier0 label

merged

mentioned in commit a37e95c5

mentioned in merge request !69214 (merged)