Skip to content
Snippets Groups Projects

AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup

Merged AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup
fwinkl/athena:athpool_test into 24.0
Merged Frank Winklmeier requested to merge fwinkl/athena:athpool_test into 24.0

Migrate remaining active tests in the AthenaPoolTest package to CA.

Also delete the LArCellContRead/Write tests (see discussion on !69173 (merged)) and remove the unused CaloClusterReader/Write job options and code.

cc @tadej @wlampl

Edited by Frank Winklmeier

Merge request reports

Pipeline #6960890 passed

Stage: external

    Pipeline passed for 8bd395a6 on fwinkl:athpool_test

    Approval is optional

    Merged by Duc TaDuc Ta 1 year ago (Feb 26, 2024 9:44pm UTC)

    Merge details

    • Changes merged into 24.0 with 3008a8c5.
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Frank Winklmeier added 1 commit

      added 1 commit

      • e2fc08f8 - AthenaPoolTest: remove LArCellContRead/Write tests and unused code

      Compare with previous version

    • Frank Winklmeier changed title from AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA to AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA and cleanup

      changed title from AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA to AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA and cleanup

    • Frank Winklmeier changed the description

      changed the description

    • Frank Winklmeier mentioned in merge request !69173 (merged)

      mentioned in merge request !69173 (merged)

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • AtlasTest/DatabaseTest/AthenaPoolTest

      This merge request affects 22 files:

      • AtlasTest/DatabaseTest/AthenaPoolTest/CMakeLists.txt
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/components/AthenaPoolTest_entries.cxx

      Adding @gemmeren as watcher

    • ATLAS Robot added 24.0 Test review-pending-level-1 labels

      added 24.0 Test review-pending-level-1 labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash b4eb281c)

      Athena
      externals :white_check_mark:
      cmake :white_check_mark:
      make :white_check_mark:
      tests :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5219] (for remote access see the FAQ for MR reviewers)

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • AtlasTest/DatabaseTest/AthenaPoolTest

      This merge request affects 22 files:

      • AtlasTest/DatabaseTest/AthenaPoolTest/CMakeLists.txt
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/components/AthenaPoolTest_entries.cxx

      Adding @gemmeren as watcher

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :x: CI Result FAILURE (hash e2fc08f8)

      Athena
      externals :white_check_mark:
      cmake :white_check_mark:
      make :white_check_mark:
      tests :o:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5231] (for remote access see the FAQ for MR reviewers)

    • Lucy Lewitt
      Lucy Lewitt @llewitt ·
      Developer

      CI error. Since the file was referenced before this commit it probably exists somewhere. Perhaps it needs moving or a full path specification. L1

      EventSelector ERROR Unable to open: SimplePoolFile.root

    • Lucy Lewitt added review-user-action-required label and removed review-pending-level-1 label

      added review-user-action-required label and removed review-pending-level-1 label

    • Frank Winklmeier added 115 commits

      added 115 commits

      • e2fc08f8...aa768d2c - 113 commits from branch atlas:24.0
      • 8b7dcc46 - AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA
      • 010abca1 - AthenaPoolTest: remove LArCellContRead/Write tests and unused code

      Compare with previous version

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • AtlasTest/DatabaseTest/AthenaPoolTest

      This merge request affects 22 files:

      • AtlasTest/DatabaseTest/AthenaPoolTest/CMakeLists.txt
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/components/AthenaPoolTest_entries.cxx

      Adding @gemmeren as watcher

    • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

      added review-pending-level-1 label and removed review-user-action-required label

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash 010abca1)

      Athena
      externals :white_check_mark:
      cmake :white_check_mark:
      make :white_check_mark:
      tests :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5309] (remote access info)

    • Lucy Lewitt
      Lucy Lewitt @llewitt ·
      Developer

      Looks good to me. L1

    • Lucy Lewitt added review-approved label and removed review-pending-level-1 label

      added review-approved label and removed review-pending-level-1 label

    • Tim Martin added review-approved-point1 label

      added review-approved-point1 label

    • Frank Winklmeier added 1 commit

      added 1 commit

      • 8bd395a6 - AthenaPoolTest: migrate InDetRawData tests to CA

      Compare with previous version

    • Frank Winklmeier changed title from AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA and cleanup to AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup

      changed title from AthenaPoolTest: migrate AthenaPoolTestRead/Write to CA and cleanup to AthenaPoolTest: migrate AthenaPoolTest and InDetRawData to CA and cleanup

    • Frank Winklmeier changed the description

      changed the description

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • AtlasTest/DatabaseTest/AthenaPoolTest

      This merge request affects 30 files:

      • AtlasTest/DatabaseTest/AthenaPoolTest/CMakeLists.txt
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/InDetRawDataReader.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/python/InDetRawDataWriter.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestWrite.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/CaloClusterWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoRead.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataReader.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataWriter.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContRead.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContReader_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter.ref
      • AtlasTest/DatabaseTest/AthenaPoolTest/share/LArCellContWriter_jobOptions.py
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeReader.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.cxx
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/CaloClusterFakeWriter.h
      • AtlasTest/DatabaseTest/AthenaPoolTest/src/components/AthenaPoolTest_entries.cxx

      Adding @gemmeren as watcher

    • ATLAS Robot added review-pending-level-1 label and removed review-approved review-approved-point1 labels

      added review-pending-level-1 label and removed review-approved review-approved-point1 labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :warning: WARNING: big files (>100K) are found in the changeset

      :pencil: 496K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataReader.ref

      :pencil: 252K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataWriter.ref

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash 8bd395a6)

      Athena
      externals :white_check_mark:
      cmake :white_check_mark:
      make :white_check_mark:
      tests :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5343] (remote access info)

    • Lucy Lewitt added Legacy Config Removal review-approved labels and removed review-pending-level-1 label

      added Legacy Config Removal review-approved labels and removed review-pending-level-1 label

    • Tim Martin added review-approved-point1 label

      added review-approved-point1 label

    • Duc Ta added review-approved-tier0 label

      added review-approved-tier0 label

    • Duc Ta mentioned in commit 3008a8c5

      mentioned in commit 3008a8c5

    • Duc Ta merged

      merged

    • Tadej Novak mentioned in merge request !69269 (merged)

      mentioned in merge request !69269 (merged)

    • Frank Winklmeier mentioned in merge request !68956 (merged)

      mentioned in merge request !68956 (merged)

    Please register or sign in to reply