Skip to content
Snippets Groups Projects

MicroMega fast digi for Phase II -- Fix chamber assignment

Merged Johannes Junggeburth requested to merge jojungge/athena:MmFastDigiPhaseII into main
All threads resolved!

Merge request reports

Checking pipeline status.

Approval is optional

All merge request dependencies have been merged (1 merged)

Merged by Tadej NovakTadej Novak 1 year ago (Feb 26, 2024 2:00pm UTC)

Merge details

  • Changes merged into main with 5e9b88ba (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • added 1 commit

    • 630c25f7 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @toyamaza ,@jojungge ,@cvarni ,@tbold ,@apsallid ,@kluit ,@adye ,@rosati ,@stavrop ,@pscholer ,@pagessin as watchers

  • :white_check_mark: CI Result SUCCESS (hash efe07f5f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5294] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 630c25f7)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5295] (remote access info)

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • added 1 commit

    • d2cd27d6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @rosati ,@tbold ,@apsallid ,@pagessin ,@jojungge ,@adye ,@pscholer ,@kluit ,@cvarni ,@stavrop ,@toyamaza as watchers

  • :x: CI Result FAILURE (hash d2cd27d6)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5314] (remote access info)

  • Fairly sure the CI failure is unrelated, I think I've seen it show up elsewhere too :disappointed:. Approving for now. L1

    ActsStripSpacePointAnalysisAlg                         1     0   ERROR Space point has Element links but not bare pointers to cluster. This should not happen!
    Edited by Lucy Lewitt
  • added review-approved label and removed review-pending-level-1 label

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @pagessin ,@stavrop ,@kluit ,@jojungge ,@pscholer ,@cvarni ,@rosati ,@toyamaza ,@apsallid ,@tbold ,@adye as watchers

  • added review-pending-level-1 label and removed review-approved label

  • Tadej Novak enabled an automatic merge when the pipeline for d2cd27d6 succeeds

    enabled an automatic merge when the pipeline for d2cd27d6 succeeds

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • added 1 commit

    • 5a7178be - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @kluit ,@tbold ,@rosati ,@cvarni ,@pscholer ,@adye ,@pagessin ,@jojungge ,@stavrop ,@toyamaza ,@apsallid as watchers

  • added review-pending-level-1 label and removed review-approved label

  • :white_check_mark: CI Result SUCCESS (hash d2cd27d6)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5320] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 5a7178be)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5322] (remote access info)

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • added 1 commit

    • 5c8a356e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

    Affected files list will not be printed in this case

    Adding @rosati ,@jojungge ,@stavrop ,@toyamaza ,@kluit ,@pagessin ,@tbold ,@pscholer ,@cvarni ,@adye ,@apsallid as watchers

  • :white_check_mark: CI Result SUCCESS (hash 5c8a356e)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5331] (remote access info)

  • merged

  • Tadej Novak mentioned in commit 5e9b88ba

    mentioned in commit 5e9b88ba

  • Please register or sign in to reply
    Loading