Only book some LAr DT monitoring histograms if in the online environment.

Also, add a fix for StatelessPT_NewConfig so that it works with older and newer releases (cil.Load went from list to set type). These changes impact LAr online and offline monitoring.

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 2 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/share/StateLessPT_NewConfig.py

Adding @pavol as watcher

added 24.0 DQ LAr Trigger review-pending-level-1 labels

CI Result FAILURE (hash 7e8f690b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5330] (remote access info)

added 1 commit

• 01515533 - Fix a bug with the LB number for DT monitoring plots

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 3 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/share/StateLessPT_NewConfig.py
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.cxx

Adding @pavol as watcher

CI Result FAILURE (hash 01515533)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5337] (remote access info)

@ekay Are the CI ouput changes expected? L1

  15:57:44 larDigitalTriggM...LArDigitalTriggerMon_digi_EMBPA           0   ERROR No monitored variables created based on histogram definition: [] Remove this monitoring tool or check its configuration.

added review-user-action-required label and removed review-pending-level-1 label

Hi @llewitt I think these are to be expected. I did quite a severe cleaning of the offline plots, since at the moment we use a lot of plots for online monitoring but don't need so many offline. As a result of the cleaning, we no longer have any per-partition plots offline. This seems consistent with the CI complaints. The idea is to remove all of these plots offline for now, and we may gradually re-introduce any if we find a need for them in future.

removed review-user-action-required label

added review-user-action-required label

added 1 commit

• ba8143ab - Fix the assignment of the partition/layer

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 4 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/share/StateLessPT_NewConfig.py
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.cxx
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.h

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• f2afeea7 - Add per partition coverage plots for DT when running offline

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArMonitoring

This merge request affects 4 files:

• LArCalorimeter/LArMonitoring/python/LArDigitalTriggMonAlg.py
• LArCalorimeter/LArMonitoring/share/StateLessPT_NewConfig.py
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.cxx
• LArCalorimeter/LArMonitoring/src/LArDigitalTriggMonAlg.h

Adding @pavol as watcher

OK, I wonder if this is a subtlety of these AthMonitorCfgHelper arrays which don't like to have no histograms defined for certain patterns. I tried adding just one of the per-partition plots to the offline config and will see what the CI says.

CI Result FAILURE (hash ba8143ab)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5491] (remote access info)

CI Result SUCCESS (hash f2afeea7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5492] (remote access info)

MR given back to developer due to unresolved threads.

Cheers, Yuriy (L1)