Import HGTD VertexTimeAlg
Following a discussion after !68235 (closed) was opened with the decision to implement an algorithm rather than a tool to decorate vertices with timing information, this MR imports the vertex time algorithm used to reconstruct the timing properties of vertices.
All comments from @tstreble in !68235 (closed) that were not directly addressed in the corresponding threads were acknowledged for this code.
Merge request reports
Activity
assigned to @jedebevc
Marked as a draft for now for the purposes of review and a few further points to clarify:
- The weights file for the BDT is still old (from Release 20.20), since we do not yet have samples that would enable re-training. Should we wait with the merge until re-training in the new release is done, or do we update the weights file in a later MR?
- A review of the BDT code to ensure that it is properly implemented in a thread-safe way would be welcome.
added 1170 commits
-
dbdd84d1...1ba2e00f - 1169 commits from branch
atlas:main
- 26256be2 - Merge branch 'main' into 'jedebevc/import-VertexTimeAlg'
-
dbdd84d1...1ba2e00f - 1169 commits from branch
This merge request affects 1 package:
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs
This merge request affects 6 files:
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/CMakeLists.txt
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/share/TMVA.VBFinv.mu200.Step3p1.8var.weights.xml
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/Clustering.h
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/VertexTimeAlg.cxx
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/VertexTimeAlg.h
- HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/components/HGTD_RecAlgs_entries.cxx
added HGTD main review-pending-level-1 labels
CI Result SUCCESS (hash 26256be2)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5553] (remote access info)removed review-pending-level-1 label
added review-approved label
mentioned in commit ad8aef27
mentioned in merge request !69404 (merged)
mentioned in merge request !68235 (closed)
mentioned in merge request !69934 (merged)
mentioned in merge request !70501 (merged)