CP algs: Move main tests to CA

Move main CP algorithms tests to CA. This is draft for now due to the following caveats

• will eventually re-target to 24.0 once the CI will be green here to properly test for the analysis
• taus SFs differ for sequences

Note this is just part one that will also go to 24.0 to avoid having integration tests running legacy configuration.

/cc @krumnack @gwatts @ekourlit @jcatmore @jchapman @nstyles

Jenkins please retry a build

This merge request affects 2 packages:

• AtlasTest/CITest
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

Affected files list will not be printed in this case

Adding @krumnack ,@tadej ,@fwinkl ,@pagessin as watchers

added Analysis CPAlgorithms Test analysis-review-required main labels

CI Result FAILURE (hash 89707144)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5458] (remote access info)

added 1 commit

• 8894ff13 - Tests fixes

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• AtlasTest/CITest
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

Affected files list will not be printed in this case

Adding @pagessin ,@fwinkl ,@tadej ,@krumnack as watchers

CI Result FAILURE (hash 8894ff13)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5470] (remote access info)

added full-unit-tests label

added 27 commits

• 8894ff13...632a7498 - 23 commits from branch atlas:main
• e7e08ab9 - TrigGlobalEfficiencyCorrectionTool: Fix FPE
• 63a1a4aa - compareFlatTrees: Avoid canvas update if a branch fails
• a7911fff - CP algs: Make PRW config more robust
• e1b4fafa - CP algs: Move main tests to CA

Compare with previous version

Jenkins please retry a build

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 6 packages:

• AtlasTest/CITest
• Control/AthToolSupport/AsgTesting
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/D3PDTools/AnaAlgorithm
• Trigger/TrigAnalysis/TrigGlobalEfficiencyCorrection

Affected files list will not be printed in this case

Adding @tadej ,@krumnack ,@fwinkl ,@ssnyder ,@pagessin as watchers

added Core Trigger labels

CI Result FAILURE (hash e1b4fafa)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5487] (remote access info)

Test failures are unrelated.

I will wait a day for feedback and then re-target to 24.0.

added review-pending-expert label

marked this merge request as ready

Will anybody actually be using CP algorithms in 24.0? My feeling is that we could probably just disable the tests there.

resolved all threads

Let me just add analysis-approval here. It is mostly updating the athena configuration of the CP algorithms to the current athena paradigm.

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

added 289 commits

• e1b4fafa...c61daa03 - 287 commits from branch atlas:main
• dc5a6533 - CP algs: Make PRW config more robust
• b1d29ae7 - CP algs: Move main tests to CA

Compare with previous version

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 4 packages:

• AtlasTest/CITest
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/D3PDTools/AnaAlgorithm

Affected files list will not be printed in this case

Adding @krumnack ,@pagessin ,@fwinkl ,@tadej as watchers

added review-pending-level-1 label and removed review-pending-expert label

CI Result FAILURE (hash b1d29ae7)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5719] (remote access info)

Test failure is unrelated.

resolved all threads

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit f660b8c0

mentioned in merge request !69962 (closed)