main-coverity-AthenaMonitoringKernel

Coverity defect 19781: Line 56 (return vars.var[0]->size();) is unreachable. All cases, with returns, were handled in the previous 'if' structure so the last line of the 'fill' function was dead code. I made this explicit and adjusted the indentation to make the 'if' nesting clearer

Targeting 'main'; this is a code quality issue. Tagging author @llewitt in case this was not their intention.

This merge request affects 1 package:

• Control/AthenaMonitoringKernel

This merge request affects 1 file:

• Control/AthenaMonitoringKernel/src/HistogramFiller/HistogramFiller2DProfile.h

Adding @maszyman ,@ssnyder ,@gemmeren as watchers

added Core DQ main review-pending-level-1 labels

Also tagging @will ; this originates from !69237 (merged) in rel.24.0

Yeah I can't really comment on this as the line's I touched were just an indent change and adding a variable so shouldn't affect any control flow.

326f2343

Yeah I did notice that line was unreachable at the time and just left it because, well, meh. I'm very happy with this coverity fixup!

CI Result SUCCESS (hash 0aa3581f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5558] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 154cb57a