Skip to content
Snippets Groups Projects

GeneratorFilters: fix logic of the (xAOD)XtoVVDecayFilterExtended.cxx

Merged Ewelina Maria Lobodzinska requested to merge ewelina/athena:main-ext into main
All threads resolved!

fix logic of the (xAOD)XtoVVDecayFilterExtended.cxx to be consistent with what is done for HepMC2 version of the filter, in the current HepMC3 approach one generation of the ancestors was skipped For info @qidong

Edited by Ewelina Maria Lobodzinska

Merge request reports

Pipeline #6984038 passed

Pipeline passed for 21fd82fb on ewelina:main-ext

Approval is optional

Merged by Tadej NovakTadej Novak 1 year ago (Mar 1, 2024 7:15pm UTC)

Merge details

  • Changes merged into main with dd812c59 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lucy Lewitt
  • Suggestions are not essential but consistent indenting is always nice :slight_smile:. L1

  • added 1 commit

    • 27ad20bf - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • resolved all threads

  • added 1 commit

    • 21fd82fb - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 1 package:

    • Generators/GeneratorFilters

    This merge request affects 2 files:

    • Generators/GeneratorFilters/src/XtoVVDecayFilterExtended.cxx
    • Generators/GeneratorFilters/src/xAODXtoVVDecayFilterExtended.cxx
  • This merge request affects 1 package:

    • Generators/GeneratorFilters

    This merge request affects 2 files:

    • Generators/GeneratorFilters/src/XtoVVDecayFilterExtended.cxx
    • Generators/GeneratorFilters/src/xAODXtoVVDecayFilterExtended.cxx
  • :white_check_mark: CI Result SUCCESS (hash 21fd82fb)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5602] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 27ad20bf)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5601] (remote access info)

  • Looks good to me. L1

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Tadej Novak mentioned in commit dd812c59

    mentioned in commit dd812c59

  • Please register or sign in to reply
    Loading