MuonChamberR4 - Fix boundaries of the chamber

• Fix orientation of the muon chamber to match with the convention

  • x-axis: Parallel to the tubes
  • y-axis: Points along the tube plane
  • z-axis: points Outwards of the detector

• Simplify ChamberTool test and add it to the list of unit tests.

• Approximate chamber boundaries by a surrounding box

• Make unit tests to run in their own directory (@fwinkl)

Tagging @damperia, @maharris

added 121 commits

• 2b037127...c61daa03 - 116 commits from branch atlas:main
• 74e1f765 - Fix chamber bounds vol I
• bb4b38c5 - Add reset capability
• 437fb9df - Do not sort the chambers by pointer address
• 7f04af7a - Add unit test
• 0c7cc037 - Fix simulation WARNING

Compare with previous version

added 1 commit

• 0263fa67 - Fix rotation of the chamber. Aproximate chambers by boxes for now.

Compare with previous version

added 1 commit

• 9c807f27 - Minor clean-up

Compare with previous version

Jenkins please retry a build

This merge request affects 4 packages:

• MuonSpectrometer/MuonPhaseII/ActsMuonDetector
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4

Affected files list will not be printed in this case

Adding @adye ,@toyamaza ,@apsallid ,@rosati ,@stavrop ,@kluit ,@tbold ,@cvarni ,@pscholer ,@jojungge ,@pagessin as watchers

added ACTS MuonSpectrometer Upgrade main labels

marked this merge request as ready

added review-pending-level-1 label

changed the description

mentioned in merge request !69412 (closed)

CI integration tests for projects AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 9c807f27)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5729] (remote access info)

added 1 commit

• 5656df2c - Guard operator

Compare with previous version

This merge request affects 4 packages:

• MuonSpectrometer/MuonPhaseII/ActsMuonDetector
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4

Affected files list will not be printed in this case

Adding @rosati ,@tbold ,@stavrop ,@kluit ,@apsallid ,@toyamaza ,@jojungge ,@adye ,@cvarni ,@pagessin ,@pscholer as watchers

CI Result SUCCESS (hash 5656df2c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5734] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 6aeef40f

mentioned in merge request !69053 (closed)