LArReadoutGeometry: Fix cppcheck warnings.

Pass objects by const reference. Suppress false positve where cppcheck doesn't handle CachedValue properly.

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• LArCalorimeter/LArGeoModel/LArReadoutGeometry

This merge request affects 2 files:

• LArCalorimeter/LArGeoModel/LArReadoutGeometry/LArReadoutGeometry/FCAL_ChannelMap.h
• LArCalorimeter/LArGeoModel/LArReadoutGeometry/src/EMECDetectorManager.cxx

Adding @pavol as watcher

added LAr main review-pending-level-1 labels

CI Result SUCCESS (hash 5fa6be2d)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5663] (remote access info)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit de2b8264