Asynchronous I/O in HltEventLoopMgr: copy to new class

Copy of Rafal Bielski's changes from !59680 (closed) ATR-26285. Since this is a near-complete rewrite of HltEventLoopMgr, make this a configurable change with the new flag Trigger.enableAsyncIO. This should allow easier testing and swapping out, particularly given the currently unsolved problems with timeouts. Once these are understood, we can rename HltAsyncEventLoopMgr to HltEventLoopMgr and just keep it as the default.

cc @ssottoco @fwinkl

Cheers,

Stewart

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @martindl ,@fpastore ,@stelzer ,@wiedenma ,@fwinkl as watchers

added Trigger analysis-review-required full-unit-tests main review-pending-level-1 labels

If this is meant for easier testing/debugging then this should go into 24.0.

changed target branch from main to 24.0

marked this merge request as draft

removed analysis-review-required label

added 2 commits

• ea4267e4 - Copy of async IO HltEventLoopMgr into new class for easier testing
• 6be77802 - Control setting up asyncIO by temporary flag

Compare with previous version

removed main label

added 24.0 label

resolved all threads

marked this merge request as ready

CI Result FAILURE (hash ba8fa879)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5755] (remote access info)

Tests pass except for known unrelated issue ATLASRECTS-7925

Jenkins please retry a build

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigEvent/TrigSteeringEvent
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @fpastore ,@stelzer ,@wiedenma ,@fwinkl ,@martindl as watchers

CI Result SUCCESS (hash 6be77802)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5836] (remote access info)

I did not spot any immediate issues, but since the new added class HltAsyncEventLoopMgr si quite complex, I would appreciate another look by the L2 shifter.

L1 shifter

added review-pending-level-2 label and removed review-pending-level-1 label

From a C++ standpoint, and focusing on paces where "thread" is mentioned to focus on the new Async code w.r.t. the current EventLoopMgr - I didn't spot any issues.

Passing on to @fwinkl & @ssottoco for review-pending-expert

Tim L2

added review-pending-expert label and removed review-pending-level-2 label

removed review-pending-expert label

added review-approved label

added review-approved-point1 label

merged

mentioned in commit d4bb65a2

mentioned in merge request !69580 (merged)

mentioned in merge request !70192 (merged)