Skip to content
Snippets Groups Projects

Included new alg to thin cells to AOD

Merged Mateus Hufnagel requested to merge mhufnage/athena:LArContainerThinner into main
All threads resolved!

This MR is to include:

  • A new algorithm (LArClusterCellDumper/CaloThinCellsInAODAlgConfig) that thin containers from: LArRawChannels, CaloCell and LArDigits from Clusters region, approved by pt/eta criteria, and writes to AOD.
  • New flag flags.Calo.TopoCluster.xtalkInfoDumper (CaloRec/CaloConfigFlags.py) set to False by default.
  • It runs on CaloRec/CaloRecConfig.py.

This development is in the context of the QT of @mhufnage, related to cross-talk mitigation studies at LAr Calorimeter.

ping @gunal , @laforge, @pavol , @eegidiop , @monnier , @lucianom

Merge request reports

Pipeline #7012395 passed

Pipeline passed for c16f4c6d on mhufnage:LArContainerThinner

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Mar 7, 2024 7:06pm UTC)

Merge details

  • Changes merged into main with 75fc7b90 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Please find above some comments/questions from the review

    L1 shifter

  • Mateus Hufnagel added 1013 commits

    added 1013 commits

    Compare with previous version

  • This merge request affects 2 packages:

    • Calorimeter/CaloRec
    • LArCalorimeter/LArClusterCellDumper

    Affected files list will not be printed in this case

    Adding @pavol ,@dossantn as watchers

  • Mateus Hufnagel resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 7e17a179)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5934] (remote access info)

  • Mateus Hufnagel added 1 commit

    added 1 commit

    • c16f4c6d - Fix headers and removed MC property.

    Compare with previous version

  • This merge request affects 2 packages:

    • Calorimeter/CaloRec
    • LArCalorimeter/LArClusterCellDumper

    Affected files list will not be printed in this case

    Adding @pavol ,@dossantn as watchers

  • :white_check_mark: CI Result SUCCESS (hash c16f4c6d)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5938] (remote access info)

  • Looks good to me noweview-pe. Approved.

    Cheers L1

  • Vakhtang Tsulaia mentioned in commit 75fc7b90

    mentioned in commit 75fc7b90

  • Please register or sign in to reply
    Loading