Andrej Saibel corrections to SFGen Athena interface
This is the merge request for the SFGen interface with some small correction suggested by @asaibel. Tagging @gpanizzo and @ewelina .
FIX AGENE-2074
Merge request reports
Activity
added Build Generators main labels
added review-pending-level-1 label
CI Result SUCCESS (hash 8d820f16)Athena AthGeneration externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5961] (remote access info)added review-user-action-required label and removed review-pending-level-1 label
Yes, these are only two small updates to the documentation. But, unless @asaibel has further suggestion to give, I think it will be all.
Cheers, Lorenzo.
@asaibel sorry if I mind you, but could you please confirm if what I have done is correct or not?
Cheers, Lorenzo.
added review-approved label and removed review-user-action-required label
Totally fine by me. Just wanted to make sure nothing got lost somewhere.
Sorry that this has been hanging so long. For next time, if you have answered such a question from your side it is best to just swap the label back to review-pending-level-1 . Reviews work on a shifter basis and we usually do not check back on MRs manually. And direkt tagging might also not work as the shift who wrote the initial comment might not be on.
With this confirmation now i have nothing else to note. Approved.
Cheers L1
mentioned in commit bdd5ef74