Move the Info class outside of the IMCTruthClassifier class

Move the Info class outside of the IMCTruthClassifier class. With this change it becomes very straightforward to inherit from the Info class.

Jenkins please retry the build

This merge request affects 1 package:

• PhysicsAnalysis/MCTruthClassifier

This merge request affects 1 file:

• PhysicsAnalysis/MCTruthClassifier/MCTruthClassifier/IMCTruthClassifier.h

Adding @zmarshal as watcher

added Analysis analysis-review-required main labels

CI integration tests for projects Athena,AthGeneration,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 125a5c92)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 28
AthGeneration: number of compilation errors 2, warnings 0
AnalysisBase: number of compilation errors 4, warnings 2
AthAnalysis: number of compilation errors 4, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6285] (remote access info)

added 1 commit

• 953c4dae - Update IMCTruthClassifier.h

Compare with previous version

added 55 commits

• 953c4dae...9cb26ae7 - 53 commits from branch atlas:main
• a0d9d9fb - Merge remote-tracking branch 'upstream/main' into 12032024i
• 03225a5a - Explicit namespace

Compare with previous version

Jenkins please retry the build

This merge request affects 1 package:

• PhysicsAnalysis/MCTruthClassifier

This merge request affects 5 files:

• PhysicsAnalysis/MCTruthClassifier/MCTruthClassifier/IMCTruthClassifier.h
• PhysicsAnalysis/MCTruthClassifier/MCTruthClassifier/MCTruthClassifier.h
• PhysicsAnalysis/MCTruthClassifier/Root/MCRecoToTruth.cxx
• PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx
• PhysicsAnalysis/MCTruthClassifier/src/MCTruthClassifierAthena.cxx

Adding @zmarshal as watcher

CI integration tests for projects Athena,AthGeneration,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 03225a5a)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 14
AthGeneration: number of compilation errors 2, warnings 0
AnalysisBase: number of compilation errors 4, warnings 2
AthAnalysis: number of compilation errors 4, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6321] (remote access info)

added 1 commit

• e2e8b5ea - Should fix compilation

Compare with previous version

Jenkins please retry the build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• PhysicsAnalysis/MCTruthClassifier

This merge request affects 5 files:

• PhysicsAnalysis/MCTruthClassifier/MCTruthClassifier/IMCTruthClassifier.h
• PhysicsAnalysis/MCTruthClassifier/MCTruthClassifier/MCTruthClassifier.h
• PhysicsAnalysis/MCTruthClassifier/Root/MCRecoToTruth.cxx
• PhysicsAnalysis/MCTruthClassifier/Root/MCTruthClassifierGen.cxx
• PhysicsAnalysis/MCTruthClassifier/src/MCTruthClassifierAthena.cxx

Adding @zmarshal as watcher

CI integration tests for projects Athena,AthGeneration are cancelled because of compilation error(s)

CI Result FAILURE (hash e2e8b5ea)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 8, warnings 0
AthGeneration: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6337] (remote access info)

added 40 commits

• e2e8b5ea...3c758097 - 38 commits from branch atlas:main
• e192eab3 - Merge remote-tracking branch 'upstream/main' into 12032024i
• 748da98c - Replace the names

Compare with previous version

Jenkins please retry the build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 9 packages:

• Generators/GeneratorFilters
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
• PhysicsAnalysis/D3PDMaker/egammaD3PDMaker
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• Reconstruction/egamma/EgammaPhysValMonitoring
• Reconstruction/egamma/egammaAlgs

Affected files list will not be printed in this case

Adding @zmarshal ,@fcardill ,@goetz ,@emmat ,@yoyamagu ,@jcatmore as watchers

added Derivation Egamma Generators Reconstruction labels

CI Result SUCCESS (hash 748da98c)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6350] (remote access info)

added 27 commits

• 748da98c...da0cad55 - 26 commits from branch atlas:main
• b91a622a - Merge remote-tracking branch 'upstream/main' into 12032024i

Compare with previous version

added 90 commits

• b91a622a...bc5f4854 - 89 commits from branch atlas:main
• 52ea1354 - Merge remote-tracking branch 'upstream/main' into 12032024i

Compare with previous version

Jenkins please retry the build.

This merge request affects 9 packages:

• Generators/GeneratorFilters
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
• PhysicsAnalysis/D3PDMaker/egammaD3PDMaker
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• Reconstruction/egamma/EgammaPhysValMonitoring
• Reconstruction/egamma/egammaAlgs

Affected files list will not be printed in this case

Adding @yoyamagu ,@fcardill ,@jcatmore ,@emmat ,@goetz ,@zmarshal as watchers

CI Result SUCCESS (hash 52ea1354)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6426] (remote access info)

added 17 commits

• 52ea1354...7306b685 - 16 commits from branch atlas:main
• 85668208 - Merge branch athena:main into 12032024i

Compare with previous version

changed title from Draft: Move the Info class outside of the MCTruthPartClassifier class to Draft: Move the Info class outside of the IMCTruthClassifier class

changed the description

marked this merge request as ready

added review-pending-level-1 label

MR looks good to me, approving.

Cheers, L1

removed review-pending-level-1 label

added review-approved label

Looks ok to me. Approving from the analysis release side.

removed analysis-review-required label

added analysis-review-approved label

Hi @averbyts,

conflicts, unfortunately. Please resolve them.

Sorry for the complication, Walter

added review-user-action-required label

added 51 commits

• 85668208...e114c966 - 50 commits from branch atlas:main
• 8c85ad4e - Merge branch 'main' into '12032024i'

Compare with previous version

Hi @wlampl,

Done! Please have a look.

Andrii

removed review-user-action-required label

This merge request affects 9 packages:

• Generators/GeneratorFilters
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
• PhysicsAnalysis/D3PDMaker/egammaD3PDMaker
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• Reconstruction/egamma/EgammaPhysValMonitoring
• Reconstruction/egamma/egammaAlgs

Affected files list will not be printed in this case

Adding @jcatmore ,@emmat ,@fcardill ,@goetz ,@yoyamagu ,@zmarshal as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash 8c85ad4e)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6494] (remote access info)

added review-approved label and removed review-pending-level-1 label

Hi @averbyts,

looks like all your MR are on collision course ... conflict again.

• Walter

added 11 commits

• 8c85ad4e...8ddf5d23 - 10 commits from branch atlas:main
• d7a974ca - Merge remote-tracking branch 'upstream/main' into 12032024i

Compare with previous version

This merge request affects 9 packages:

• Generators/GeneratorFilters
• PhysicsAnalysis/D3PDMaker/MuonD3PDMaker
• PhysicsAnalysis/D3PDMaker/egammaD3PDAnalysis
• PhysicsAnalysis/D3PDMaker/egammaD3PDMaker
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/MCTruthClassifier
• Reconstruction/egamma/EgammaPhysValMonitoring
• Reconstruction/egamma/egammaAlgs

Affected files list will not be printed in this case

Adding @fcardill ,@emmat ,@goetz ,@yoyamagu ,@zmarshal ,@jcatmore as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash d7a974ca)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6511] (remote access info)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 73f29328