RDBAccessSvc: Fix cppcheck warnings.

Pass strings by const reference, not by value. Copying value in range-for.

This merge request affects 1 package:

• Database/RDBAccessSvc

This merge request affects 3 files:

• Database/RDBAccessSvc/src/RDBVersionAccessor.cxx
• Database/RDBAccessSvc/src/RDBVersionAccessor.h
• Database/RDBAccessSvc/src/SourceCompAlg.cxx

Adding @ssnyder as watcher

added Database main review-pending-level-1 labels

CI Result SUCCESS (hash 62f7a978)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6310] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving. L1 shifter

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 3be8e270