Check efex loaded noise cuts and dm corrections are valid

Update eTowerMakerFromEfexTowers.cxx - stop if no noise cuts loaded for event (e.g. if user made sqlite file's IOV wasn't broad enough to cover the event being processed)

Similar update to eFEXegAlgo.cxx

added 1 commit

• 0acfef74 - Update eFEXegAlgo.cxx - protect against missing dm corrections from database

Compare with previous version

marked this merge request as ready

changed the description

jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @thompson ,@will as watchers

added 24.0 L1Calo Trigger review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 0acfef74)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6371] (remote access info)

added 1 commit

• 4bfc5718 - Update eFEXegAlgo.cxx

Compare with previous version

added 1 commit

• cbcb622d - Update eTowerMakerFromEfexTowers.cxx

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @thompson ,@will as watchers

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash cbcb622d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6373] (remote access info)

CI Result FAILURE (hash 4bfc5718)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6372] (remote access info)

added 1 commit

• 8d612ba1 - Update eFEXegAlgo.cxx

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 2 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @thompson ,@will as watchers

CI Result FAILURE (hash 8d612ba1)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6374] (remote access info)

The new error introduced in eFEXegAlgo.cxx leads to failures in the CITest_RecoRun3Data_Cosmics test and L1CaloFEXSim_L1CaloFEXSimCfg_R2data unit test. Please have a look how to avoid these failures.

L1 shifter

added review-user-action-required label and removed review-pending-level-1 label

removed review-user-action-required label

jenkins please retry a build

added 1 commit

• 1b3acbb9 - Update L1CaloFEXSimCfg.py - don't use db for DM corrections when running on really early data

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @thompson ,@will as watchers

added review-pending-level-1 label

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

CI Result FAILURE (hash 1b3acbb9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7452] (remote access info)

CI Result FAILURE (hash 8d612ba1)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7449] (remote access info)

added 1 commit

• 36439e1e - Update eFEXegAlgo.cxx - print key of dmCorrections in error (should have been empty)

Compare with previous version

added 1 commit

• b7ca8733 - Update L1CaloFEXSimCfg.py - don't connect conditions folder unless using it

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

CI Result FAILURE (hash 36439e1e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7498] (remote access info)

CI Result FAILURE (hash b7ca8733)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7499] (remote access info)

added 1 commit

• 951908a9 - Update L1CaloFEXSimCfg.py - fix typo

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @thompson ,@will as watchers

CI Result FAILURE (hash 951908a9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7504] (remote access info)

There's still a failing CI test: CITest_Trigger_athenaHLT_v1Dev-test which says trigger counts have changed - could you check if this is expected, and if so update the reference files?
Albert (L1)

added review-user-action-required label and removed review-pending-level-1 label

The test file here is data22, so seems to fall in your exception, hence the change of counts?

For Enhanced Bias data we're limited to data22, but we could maybe rustle up some data23 to check consistency on if this would be useful.

added 1 commit

• 0efa3f2a - Update L1CaloFEXSimCfg.py

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 0efa3f2a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8959] (remote access info)

added 1 commit

• cf9aa200 - Update L1CaloFEXSimCfg.py

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

This merge request affects 3 files:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/python/L1CaloFEXSimCfg.py
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eTowerMakerFromEfexTowers.cxx

Adding @will ,@thompson as watchers

CI Result FAILURE (hash cf9aa200)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8967] (remote access info)

added 1 commit

• 31c7947c - Update L1CaloFEXSimCfg.py

Compare with previous version