cTAU algorithm upgrade - added eTAU rCore/BDT and rHad score cuts
Hopefully, this is the last change we need to add to the cTAU algorithm (ATR-28641).
This MR adds the eTAU rCore/BDT and rHad selections on the cTauMultiplicity L1Topo algorithm and in the RoI construction during the HLT Seeding. It's disabled by default, so that we don't introduce any immediate changes until the change is implemented in the L1Topo firmware, and the tuning is complete.
In the cTAU algorithm, we cannot cut on arbitrary values of the rCore/BDT and rHad scores, since they're not included in the eTAU TOB (only on the xTOB). We select the minimum eTAU WPs that the TOBs are required to pass (None, Loose, Medium, or Tight, each instead defined in the eTAU configuration) for each cTAU WP. We essentially copy the behavior of the eTauMultiplicity algorithm: e.g. eTAU_TOB_rCoreMin >= cTAU_eTAU_rCoreMin_WP
(remember we are reusing on some parts of the existing code the rCore
variable to hold the BDT score).
I also fixed the passing of isolation parameters to the Multiplicity algorithms: now we fetch the settings directly from the L1ThrExtraInfo_cTAU/jTAU
objects, that we can retrieve from the L1Threshold_cTAU/jTAU
s. This required also slightly tweaking the parameters in the jTauNoSort
Athena implementation (we don't use yet anywhere in the Menu/Firmware, but the code is there nonetheless), but it's actually now closer to the L1Topo firmware implementation (and same as how we have the eTauNoSort
, eEMNoSort
, etc... implementations).
Tagging @rgugel, @thompson, @astruebi, @lidiaz, @gipezzul, @mashamim.
Merge request reports
Activity
This merge request affects 8 packages:
- Trigger/TrigConfiguration/TrigConfData
- Trigger/TrigConfiguration/TrigConfIO
- Trigger/TrigSteer/HLTSeeding
- Trigger/TrigT1/Global/GlobalSimulation
- Trigger/TrigT1/L1Topo/L1TopoAlgorithms
- Trigger/TrigT1/L1Topo/L1TopoCoreSim
- Trigger/TrigT1/L1Topo/L1TopoInterfaces
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @lidiaz ,@jmharris ,@fpastore ,@cmorenom ,@tamartin ,@stelzer ,@jchapman ,@asonay ,@oliveirg ,@paulama ,@orlando ,@sutt ,@mark ,@iriu as watchers
added 24.0 Tau Trigger TriggerMenu labels
CI Result SUCCESS (hash 39e2695d)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6363] (remote access info)added 161 commits
-
39e2695d...386ed380 - 151 commits from branch
atlas:24.0
- b0916665 - First version
- 940d7c2f - Fix typo
- 44bca970 - Small fix
- 3cec4569 - Small fix
- d76844a0 - Small fix; it compiles now
- acccfdfc - Fix small typo in the Menu config
- e1fab15d - Fix check for 'None' BDT WP
- fce2b7f0 - Disable BDT selection by default
- 24bf90e1 - Pass the eTAU version flag to twtc
- 4e795ab1 - Renamed eTAU_BDT_WP to eTAU_rCoreMin_WP; Added eTAU_rHad_WP; Change handling...
Toggle commit list-
39e2695d...386ed380 - 151 commits from branch
This merge request affects 8 packages:
- Trigger/TrigConfiguration/TrigConfData
- Trigger/TrigConfiguration/TrigConfIO
- Trigger/TrigSteer/HLTSeeding
- Trigger/TrigT1/Global/GlobalSimulation
- Trigger/TrigT1/L1Topo/L1TopoAlgorithms
- Trigger/TrigT1/L1Topo/L1TopoCoreSim
- Trigger/TrigT1/L1Topo/L1TopoInterfaces
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @jmharris ,@fpastore ,@tamartin ,@sutt ,@stelzer ,@mark ,@oliveirg ,@asonay ,@orlando ,@cmorenom ,@lidiaz ,@iriu ,@paulama ,@jchapman as watchers
CI Result SUCCESS (hash 4e795ab1)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6668] (remote access info)This merge request affects 8 packages:
- Trigger/TrigConfiguration/TrigConfData
- Trigger/TrigConfiguration/TrigConfIO
- Trigger/TrigSteer/HLTSeeding
- Trigger/TrigT1/Global/GlobalSimulation
- Trigger/TrigT1/L1Topo/L1TopoAlgorithms
- Trigger/TrigT1/L1Topo/L1TopoCoreSim
- Trigger/TrigT1/L1Topo/L1TopoInterfaces
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @lidiaz ,@asonay ,@cmorenom ,@stelzer ,@paulama ,@jmharris ,@sutt ,@fpastore ,@iriu ,@mark ,@tamartin ,@oliveirg ,@orlando ,@jchapman as watchers
added analysis-review-required review-pending-level-1 labels
CI Result FAILURE (hash 4e795ab1)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6799] (remote access info)added 67 commits
-
4e795ab1...c21d697b - 57 commits from branch
atlas:24.0
- be2bce32 - First version
- c0c3ca94 - Fix typo
- 4eaa5b42 - Small fix
- 88e9210c - Small fix
- 957d1313 - Small fix; it compiles now
- 11a054d2 - Fix small typo in the Menu config
- f3087410 - Fix check for 'None' BDT WP
- c0ff0206 - Disable BDT selection by default
- f7340264 - Pass the eTAU version flag to twtc
- b9464b03 - Renamed eTAU_BDT_WP to eTAU_rCoreMin_WP; Added eTAU_rHad_WP; Change handling...
Toggle commit list-
4e795ab1...c21d697b - 57 commits from branch
This merge request affects 8 packages:
- Trigger/TrigConfiguration/TrigConfData
- Trigger/TrigConfiguration/TrigConfIO
- Trigger/TrigSteer/HLTSeeding
- Trigger/TrigT1/Global/GlobalSimulation
- Trigger/TrigT1/L1Topo/L1TopoAlgorithms
- Trigger/TrigT1/L1Topo/L1TopoCoreSim
- Trigger/TrigT1/L1Topo/L1TopoInterfaces
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @paulama ,@fpastore ,@stelzer ,@iriu ,@asonay ,@oliveirg ,@orlando ,@jmharris ,@sutt ,@cmorenom ,@tamartin ,@jchapman ,@mark ,@lidiaz as watchers