Update AsgClassificationDecorationAlg.cxx - tool must be private for...

Update AsgClassificationDecorationAlg.cxx - tool must be private for consistency with https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/python/AsgAnalysisConfig.py#L380

@ravinab this is why the config block wasn't working in AthAnalysis, I believe

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms

This merge request affects 1 file:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/Root/AsgClassificationDecorationAlg.cxx

Adding @tadej ,@krumnack as watchers

added Analysis CPAlgorithms analysis-review-required main review-pending-level-1 labels

Let me approve on behalf of AR. This is an obvious bugfix and also puts this in line with how analysis algorithms are supposed to be written (i.e. all tools ought to be private).

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

I agree, I think long term we should migrate this all to C++17-like ToolHandles. I think this was originally written this way as it was ported from 21.2 where some modern code did not work.

Yeah, that too. Ideally (in my mind) we would get rid of all the declareProperty calls and use Gaudi::Property or the inline constructors of the various handles.

CI Result SUCCESS (hash ace2ed42)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6500] (remote access info)

Looks all good to me. Approved.

Cheers L1

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 8ddf5d23