Skip to content
Snippets Groups Projects

MuonRotCreator - Remove Csc from the generic Rot creator

Merged MuonRotCreator - Remove Csc from the generic Rot creator
jojungge/athena:removeCscClassRot into main
All threads resolved!
Merged Johannes Junggeburth requested to merge jojungge/athena:removeCscClassRot into main
All threads resolved!

There's the CscClusterOnTrackCreator for these cases.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • e9c552b8 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator

    This merge request affects 2 files:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.cxx
    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.h

    Adding @apsallid ,@pscholer ,@stavrop ,@kluit ,@goetz ,@rosati ,@jojungge as watchers

  • ATLAS Robot added Run2-DataReco-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

    added Run2-DataReco-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash e9c552b8)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6574] (remote access info)

  • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth removed Run2-DataReco-output-changed label

    removed Run2-DataReco-output-changed label

  • Johannes Junggeburth removed Run2-MCReco-output-changed label

    removed Run2-MCReco-output-changed label

  • Johannes Junggeburth removed Run3-DataReco-output-changed label

    removed Run3-DataReco-output-changed label

  • Johannes Junggeburth removed Run3-MCReco-output-changed label

    removed Run3-MCReco-output-changed label

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 8a71b380 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator

    This merge request affects 2 files:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.cxx
    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.h

    Adding @apsallid ,@jojungge ,@stavrop ,@kluit ,@goetz ,@rosati ,@pscholer as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 8a71b380)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :o:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6576] (remote access info)

  • Johannes Junggeburth
  • Johannes Junggeburth resolved all threads

    resolved all threads

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • 070c6ef5 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator

    This merge request affects 2 files:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.cxx
    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.h

    Adding @stavrop ,@jojungge ,@pscholer ,@goetz ,@rosati ,@apsallid ,@kluit as watchers

  • ATLAS Robot added Run2-DataReco-output-changed label

    added Run2-DataReco-output-changed label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 070c6ef5)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6577] (remote access info)

  • Johannes Junggeburth removed Run2-DataReco-output-changed label

    removed Run2-DataReco-output-changed label

  • Johannes Junggeburth added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator

    This merge request affects 2 files:

    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.cxx
    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator/src/MuonClusterOnTrackCreator.h

    Adding @pscholer ,@rosati ,@stavrop ,@jojungge ,@goetz ,@kluit ,@apsallid as watchers

  • ATLAS Robot added Run2-DataReco-output-changed label

    added Run2-DataReco-output-changed label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash c7b47e0c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6581] (remote access info)

  • Johannes Junggeburth added review-user-action-required label

    added review-user-action-required label

  • Johannes Junggeburth removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Johannes Junggeburth added 1 commit

    added 1 commit

    • ba8bccfc - Csc rot creator in the phi hit selector

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonClusterOnTrackCreator
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentCleaner

    Affected files list will not be printed in this case

    Adding @pscholer ,@stavrop ,@apsallid ,@jojungge ,@kluit ,@rosati ,@goetz as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Frank Winklmeier removed Run2-DataReco-output-changed label

    removed Run2-DataReco-output-changed label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ba8bccfc)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6623] (remote access info)

  • Yuriy Volkotrub
    Yuriy Volkotrub @yvolkotr ·
    Developer

    MR looks good to me thus approving - L1 shifter

  • Yuriy Volkotrub removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Yuriy Volkotrub added review-approved label

    added review-approved label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit 4dfb07aa

    mentioned in commit 4dfb07aa

    • Please register or sign in to reply