Acts TrackFinding: fix index out of bounds with useCache

• TrackFindingMeasurements::addMeasurements now uses a simple index counter instead of measurement->index() when creating MeasurementRangeList. index() gives the index into the owning collection, whereas we want the index into the input collection. These will be different if the input collection is a view.
  • Restore the ITkConversionStripClusters_InView input collection, which previously crashed with an index out of bounds in the Acts Conversion pass when flags.Acts.useCache=True:

      ActsConversionTrackFindingAlg FATAL  Standard std::exception is caught
      ActsConversionTrackFindingAlg ERROR SG::ExcBadForwardLink: ForwardIndexingPolicy: internal link state of 'DataVector<xAOD::UncalibratedMeasurement_v1>' is invalid: m_index = 142136 is >= data container size = 4910

• Fix the measurementOffsets (used by TrackStatePrinter) if there were more than 2 input collections.
• Respect EnableITkPixel and EnableITkStrip also for measurements in the Acts Main and Conversion passes. If either had been set False, there would have been a mismatch in HandleKeyArray sizes.

CC: @cvarni, @goetz

added ACTS label

added 1 commit

• 4f6c8b1b - fix comment indent

Compare with previous version

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @tbold ,@toyamaza ,@pagessin ,@adye ,@goetz ,@cvarni ,@jojungge as watchers

added Tracking main review-pending-level-1 labels

This merge request affects 2 packages:

• Tracking/Acts/ActsConfig
• Tracking/Acts/ActsTrackReconstruction

Affected files list will not be printed in this case

Adding @tbold ,@pagessin ,@toyamaza ,@goetz ,@cvarni ,@adye ,@jojungge as watchers

CI Result SUCCESS (hash 8f6d3e97)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6656] (remote access info)

CI Result SUCCESS (hash 4f6c8b1b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6657] (remote access info)

Changes look good and passes CI. Approving for L1.

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit be226bbe