Skip to content
Snippets Groups Projects

Fix Store Mechanism of TrackSeeds for Seed efficiency plotting

Merged Carlo Varni requested to merge cvarni/athena:SeedTrackProduction into main
All threads resolved!

This is to fix an issue observed by @fcastill while trying to produce Seed Efficiency plots.

Also, follow up from !63126 (merged) (/cc @lgagnon @adimitri @arastogi @spagan) and from !66977 (merged) (/cc @tstreble)

Changes: adapt mechanism for use on ITk configuration

Move flags storeTrackSeeds and storeSiSPSeededTracks also to ITk tracking passes, and setting default values related to previous config flags

Merge request reports

Pipeline #7083932 passed

Pipeline passed for 90971efe on cvarni:SeedTrackProduction

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Mar 19, 2024 4:50pm UTC)

Merge details

  • Changes merged into main with c4b5030f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • Carlo Varni resolved all threads

    resolved all threads

  • Thomas Strebler
  • This merge request affects 2 packages:

    • InnerDetector/InDetConfig
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @tstreble ,@sroe ,@goetz as watchers

  • Carlo Varni added 1 commit

    added 1 commit

    • 90971efe - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetConfig
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @tstreble ,@sroe ,@goetz as watchers

  • :white_check_mark: CI Result SUCCESS (hash 41640be8)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6680] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 163b0e0b)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6681] (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash 90971efe)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6683] (remote access info)

  • Carlo Varni resolved all threads

    resolved all threads

  • Carlo Varni mentioned in merge request !69941 (merged)

    mentioned in merge request !69941 (merged)

  • Looks all good to me. Approved. Cheers L1

  • Frank Winklmeier mentioned in commit c4b5030f

    mentioned in commit c4b5030f

  • Thomas Strebler mentioned in merge request !70582 (merged)

    mentioned in merge request !70582 (merged)

  • Please register or sign in to reply
    Loading