Do not hardcode pixel charge for ITk

Do not hardcode pixel charge for ITk. This seems to originate from DBM that we do not really support anymore so we may as well want to remove this.

/cc @stsuno @tstreble @cvarni @kbai @sroe @goetz @avallier @ncalace

added bugfix label

changed the description

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/SiClusterizationTool
• Tracking/Acts/ActsDataPreparation

Affected files list will not be printed in this case

Adding @stsuno ,@battagl ,@pagessin ,@cvarni ,@lgagnon ,@goetz ,@jojungge ,@tbold ,@sroe ,@lshan ,@toyamaza as watchers

added ACTS InnerDetector Tracking main review-pending-level-1 labels

Yes, I found this bug when I changed getChage() in Reco, but had the same getToT() Digi. I found that all the modules in the barrel and A-side endcap have moduleHash>2035, and therefore the hardcoded ToT-to-chage overwrites the getChage() from PixelChargeCalibCondData for those modules.

Also tagging @spagan.

can we remove this completely? and... should this also be in 24.0, given that it is a bugfix?

CI Result SUCCESS (hash 6e04003d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6698] (remote access info)

Hello,

I just mention that the DBM (hashID=0-11, 2035-2047) was operated in RUN2 (part of runs), and completely terminated in RUN3.

I think isDBM method is safer.

Cheers, Soshi

MR given back to developer due to unresolved thread. Cheers, L1

removed review-pending-level-1 label

added review-user-action-required label

resolved all threads

Then, MR looks good to me thus approving - L1 shifter

removed InnerDetector label

added InnerDetector label

added review-approved label and removed InnerDetector label

removed review-user-action-required label

merged

mentioned in commit 4104c132

mentioned in merge request !70020 (merged)