Remove the GenericBarcodeFilter

Remove the GenericBarcodeFilter as it is not used anywhere. Part of the migration away from barcode usage. See ATLASSIM-6906.

@jchapman @pclark

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Tools

This merge request affects 4 files:

• Simulation/ISF/ISF_Core/ISF_Tools/python/ISF_ToolsConfig.py
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.cxx
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.h
• Simulation/ISF/ISF_Core/ISF_Tools/src/components/ISF_Tools_entries.cxx

Adding @lmijovic ,@jchapman as watchers

added Simulation main review-pending-level-1 labels

changed the description

added 1 commit

• 54e0fb4b - 1 commit from branch atlas:main

Compare with previous version

added 96 commits

• 54e0fb4b...fe643ebb - 95 commits from branch atlas:main
• a1dda65e - Merge branch athena:main into 20240320c

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Tools

This merge request affects 4 files:

• Simulation/ISF/ISF_Core/ISF_Tools/python/ISF_ToolsConfig.py
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.cxx
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.h
• Simulation/ISF/ISF_Core/ISF_Tools/src/components/ISF_Tools_entries.cxx

Adding @jchapman ,@lmijovic as watchers

CI Result FAILURE (hash a1dda65e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6801] (remote access info)

CI Result SUCCESS (hash 92ba8323)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6798] (remote access info)

added 9 commits

• a1dda65e...978969f1 - 8 commits from branch atlas:main
• 6002730f - Merge branch athena:main into 20240320c

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Tools

This merge request affects 4 files:

• Simulation/ISF/ISF_Core/ISF_Tools/python/ISF_ToolsConfig.py
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.cxx
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.h
• Simulation/ISF/ISF_Core/ISF_Tools/src/components/ISF_Tools_entries.cxx

Adding @lmijovic ,@jchapman as watchers

added Run4-MCReco-output-changed label

CI Result FAILURE (hash 6002730f)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6810] (remote access info)

This seems to be a unrelated problem see ATLINFR-5304 .

~L1

Otherwise code changes are straight forward, approoving for L1.

removed Run4-MCReco-output-changed label

removed review-pending-level-1 label

added review-approved label

removed review-approved label

added Run4-MCReco-output-changed review-pending-level-1 labels

Sorry, reverting. We will need to keep the labels to track the CI issue down.

~L1

added 7 commits

• 6002730f...2e945ef4 - 6 commits from branch atlas:main
• d5c9ea7b - Merge branch athena:main into 20240320c

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Tools

This merge request affects 4 files:

• Simulation/ISF/ISF_Core/ISF_Tools/python/ISF_ToolsConfig.py
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.cxx
• Simulation/ISF/ISF_Core/ISF_Tools/src/GenericBarcodeFilter.h
• Simulation/ISF/ISF_Core/ISF_Tools/src/components/ISF_Tools_entries.cxx

Adding @jchapman ,@lmijovic as watchers

CI Result SUCCESS (hash d5c9ea7b)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6850] (remote access info)

Aprooving for L1.

removed Run4-MCReco-output-changed label

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit f6a39514