Fix issue with incomplete hashing in HLT Nav conversion
This MR fixes a very subtle bug in nav conversion. We were using a home made hashing functions to decide if two TEs were result of the same reco (i.e. can be merged). That hashing function resulted occasionally in the same hash value for actually differently made TEs. The code is now repalced by boost hash_combine.
In addition,
- revived standalone test (much faster than runnging derivation)
- setup unit tests
- added handy printer function in converter to aid future debugging
- improved messaging
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigEvent/TrigNavTools
This merge request affects 7 files:
- Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
- Trigger/TrigEvent/TrigNavTools/python/NavConverterConfig.py
- Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversionV2.py
- Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.cxx
- Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.h
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
added 24.0 Trigger review-pending-level-1 labels
CI Result SUCCESS (hash 54bad15a)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6853] (remote access info)- Resolved by Tomasz Bold
Hi @tbold -
HLTUtils::string2hash
is not affected, right? (I hope we already have suitable protection there to deal with collisions)
- Resolved by Tomasz Bold
This merge request affects 1 package:
- Trigger/TrigEvent/TrigNavTools
This merge request affects 7 files:
- Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
- Trigger/TrigEvent/TrigNavTools/python/NavConverterConfig.py
- Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversionV2.py
- Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.cxx
- Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.h
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
- Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
CI Result SUCCESS (hash 9162e4f2)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6860] (remote access info)removed review-pending-level-1 label
added review-approved label
added review-approved-point1 label
mentioned in commit 7e9e1cf5
mentioned in merge request !70026 (merged)