Skip to content
Snippets Groups Projects

Fix issue with incomplete hashing in HLT Nav conversion

Merged Tomasz Bold requested to merge tbold/athena:debug-nav-conversion into 24.0
All threads resolved!

This MR fixes a very subtle bug in nav conversion. We were using a home made hashing functions to decide if two TEs were result of the same reco (i.e. can be merged). That hashing function resulted occasionally in the same hash value for actually differently made TEs. The code is now repalced by boost hash_combine.

In addition,

  • revived standalone test (much faster than runnging derivation)
  • setup unit tests
  • added handy printer function in converter to aid future debugging
  • improved messaging

FI: @wprzygod @tamartin @khoo @mrimoldi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold added 1 commit

    added 1 commit

    • 9162e4f2 - No hand controlled output level

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigEvent/TrigNavTools

    This merge request affects 7 files:

    • Trigger/TrigEvent/TrigNavTools/CMakeLists.txt
    • Trigger/TrigEvent/TrigNavTools/python/NavConverterConfig.py
    • Trigger/TrigEvent/TrigNavTools/share/testTrigR2ToR3NavGraphConversionV2.py
    • Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.cxx
    • Trigger/TrigEvent/TrigNavTools/src/NavigationTesterAlg.h
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.cxx
    • Trigger/TrigEvent/TrigNavTools/src/Run2ToRun3TrigNavConverterV2.h
  • Tomasz Bold resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 9162e4f2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6860] (remote access info)

  • Code changes look fine from L1 perspective and the CI succeeded.

    Cheers, L1 shifter

  • mentioned in commit 7e9e1cf5

  • Frank Winklmeier mentioned in merge request !70026 (merged)

    mentioned in merge request !70026 (merged)

  • Please register or sign in to reply
    Loading