Add possiblity to use Geant4 transport instead of ATLAS tracking tools in FCS in G4

This MR adds the possibility to use the Geant4 transport instead of the ATLAS tracking tools required for transporting particles from the ID-Calo boundary through the calorimeter system for FastCaloSim. More specifically, it:

• adds a new tool G4CaloTransportTool that does the G4 transport
• the tool relies on reading in a simplified calorimeter geometry which is read in G4AtlasAlg
• the simplified geometry is a GDML file located under /cvmfs/atlas.cern.ch/repo/sw/database/GroupData/FastCaloSim/MC23/GeoFiles/v02/simplified_geo.gdml (/eos/atlas/atlascerngroupdisk/asg-calib/FastCaloSim/MC23/ )
• For now, the default behaviour will remain unchanged, but the calorimeter transport through the simplified geometry can be activated by simply providing the following preExec to the transform --preExec AtlasG4Tf:flags.Sim.SimplifiedGeoPath=FastCaloSim/MC23/GeoFiles/v02/simplified_geo.gdml'
• the FastCaloSimCaloExtrapolation tool now also provides an interface to do the extrapolation without the transportation

Note: It was attempted to make the G4CaloTransportTool thread safe by creating propagators for each unique thread with the ThreadLocalHolder. While this seems to work, there are still small MT vs. MT (ST) differences observed for 15 ttbar events. Nonetheless, it was discussed with @jchapman that this should go in first and then be discussed with the relevant Geant4 experts. Eventually, the tool should also become either part of the FastCaloSim standalone library or (ideally) directly part of Geant4.

To reproduce:

PATH_TO_SIMPLIFIED_GEO='FastCaloSim/MC23/GeoFiles/v02/simplified_geo.gdml'
export ATHENA_CORE_NUMBER=8
AtlasG4_tf.py \
   --CA \
   --multithreaded \
   --randomSeed '10' \
   --maxEvents '15' \
   --skipEvents '0' \
   --preInclude 'sim:Campaigns.MC21Simulation,SimuJobTransforms.FastCaloSim' \
   --postInclude 'default:PyJobTransforms.UseFrontier' \
   --inputEVNTFile "/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/SimCoreTests/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.evgen.EVNT.e4993.EVNT.08166201._000012.pool.root.1" \
   --outputHITSFile="test.HITS.pool.root" \
   --physicsList="FTFP_BERT_ATL" 		\
   --conditionsTag "default:OFLCOND-MC21-SDR-RUN3-07" 		\
   --geometryVersion="default:ATLAS-R3S-2021-03-00-00" 	\
   --preExec AtlasG4Tf:flags.Sim.SimplifiedGeoPath=\'${PATH_TO_SIMPLIFIED_GEO}\' \
   --imf False;

fyi @mumohdso

added 1 commit

• 004bef15 - First working CA version

Compare with previous version

added 1 commit

• 9bea9a8d - Add comment

Compare with previous version

mentioned in merge request !68368 (closed)

Currently seeing MT vs. ST differences with simplified geometry, attaching log for reference. No differences when running with default ATLAS transport.

diff.log

added 2384 commits

• 9bea9a8d...f0a98bd9 - 2367 commits from branch atlas:24.0
• f0a98bd9...717a14d3 - 7 earlier commits
• 202c916f - Minor improvements
• 91d267bb - Revert "Minor improvements"
• ef0355b8 - First MT compatible implementation
• fd9b650d - Add crashing code
• 97b7aba9 - Add temporary changes
• 54031072 - Allow MT running (not identical output to ST yet)
• 4fa3abca - Minor cleanup
• 53a6f9d0 - Rebase cleanup
• 161608a7 - First working CA version
• d59a5b2b - Add comment

Compare with previous version

added 1 commit

• 1e8692b6 - Remove unnecessary headers

Compare with previous version

resolved all threads

added 1 commit

• c11ef56d - Cleanup code

Compare with previous version

added 1 commit

• 98ed649c - Revert "Cleanup code"

Compare with previous version

added 2 commits

• c78597ee - "Cleanu code"
• 20d7dff4 - Only initialize transport tool if set

Compare with previous version

added 1 commit

• c9aaef9e - Rename G4TransportTool -> G4CaloTransportTool

Compare with previous version

Jenkins please retry a build.

This merge request affects 6 packages:

• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasInterfaces
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Utilities/G4FastSimulation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/SimulationConfig

Affected files list will not be printed in this case

Adding @jchapman ,@jbeirer ,@tadej ,@schaarsc ,@zhangr as watchers

added 24.0 Simulation analysis-review-required labels

resolved all threads

added Run2-FullSim-output-changed Run3-AF3-output-changed Run3-FullSim-output-changed Run3-HitsMerge-output-changed Run4-FullSim-output-changed labels

CI Result FAILURE (hash c9aaef9e)

	Athena	AthSimulation	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9281] (remote access info)

added 1 commit

• c144256b - Improve memory management

Compare with previous version

changed the description

@jchapman The tests are simply failing because of the change in metadata coming from the additional SimplifiedGeoPath flag. Do we just need to update the reference files?

added 1 commit

• 78e7d760 - Only add SimplifiedGeoPath to metadata if set

Compare with previous version

resolved all threads

removed Run2-FullSim-output-changed label

removed Run3-AF3-output-changed label

removed Run3-FullSim-output-changed label

removed Run3-HitsMerge-output-changed label

removed Run4-FullSim-output-changed label

marked this merge request as ready

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 6 packages:

• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasInterfaces
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Utilities/G4FastSimulation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/SimulationConfig

Affected files list will not be printed in this case

Adding @jchapman ,@jbeirer ,@schaarsc ,@zhangr ,@tadej as watchers

added review-pending-level-1 label

added 1 commit

• c419bb07 - Address comments

Compare with previous version

This merge request affects 6 packages:

• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasInterfaces
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Utilities/G4FastSimulation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/SimulationConfig

Affected files list will not be printed in this case

Adding @tadej ,@jchapman ,@schaarsc ,@jbeirer ,@zhangr as watchers

added 1 commit

• e1085f30 - Address comments

Compare with previous version

resolved all threads

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 6 packages:

• Simulation/G4Atlas/G4AtlasAlg
• Simulation/G4Atlas/G4AtlasInterfaces
• Simulation/G4Atlas/G4AtlasTools
• Simulation/G4Utilities/G4FastSimulation
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/SimulationConfig

Affected files list will not be printed in this case

Adding @schaarsc ,@zhangr ,@jbeirer ,@jchapman ,@tadej as watchers

CI Result SUCCESS (hash 78e7d760)

	Athena	AthSimulation	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9444] (remote access info)

CI Result SUCCESS (hash c419bb07)

	Athena	AthSimulation	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9453] (remote access info)

CI Result SUCCESS (hash e1085f30)

	Athena	AthSimulation	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9454] (remote access info)

MR looks fine from L1 perspective, CI shows no problems - approving

Cheers, Qiyu, L1

removed review-pending-level-1 label

added review-approved label