Skip to content

Improve consistency of InDetSimEventTPCnv behaviour.

John Derek Chapman requested to merge jchapman/athena:InDetSimEventTPCnvConsistency_main into main

In recent updates to HepMcParticleLink, it was observed that the behaviour of TRT_HitCollectionCnv_p4 and SiHitCollectionCnv_p3 differed from the behaviour of TP converter classes using HepMcParticleLinkCnv_p2 directly.

This merge request attempts to make the behaviour of SiHitCollectionCnv_p3/4and TRT_HitCollectionCnv_p4/5 consistent with HepMcParticleLinkCnv_p2/3.

This has the effect of preventing some small increases in SiHitCollection_p3 and TRT_HitCollection_p4 when comparing the output of HITSMerge_tf.py with the input HITS file.

SiHitCollectionCnv_p3_test is updated to confirm that the size of the m_barcode, m_mcEvtIndex, m_evtColl and m_nBC vector member variables of SiHitCollection_p3 no longer increase after P->T->P conversion. The Run3-HitsMerge-output-changed label is therefore expected. The result of P->T->P->T conversions is showed to be unaltered, by the changes in this merge request, as also evidenced by the fact that the digitization outputs are unchanged.

Relates to ATLASSIM-6999.

Edited by John Derek Chapman

Merge request reports