Skip to content
Snippets Groups Projects

PyUtils: Make ##Params storage technology explicit

Merged Grigori Rybkin requested to merge grybkine/athena:main-PyUtils-Params into main

Tools/PyUtils/python/AthFileLite.py: Extract file GUID in a more Pythonic way Tools/PyUtils/python/MetaReader.py: idem

Related to ATEAM-960

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks overall very good to me. I only have one minor suggestion.

    Cheers L1

  • Grigori Rybkin resolved all threads

    resolved all threads

  • Grigori Rybkin added 1 commit

    added 1 commit

    • eb53f6f6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 1 package:

    • Tools/PyUtils

    This merge request affects 2 files:

    • Tools/PyUtils/python/AthFileLite.py
    • Tools/PyUtils/python/MetaReader.py
  • @grybkine, does this MR add any functionality other than throwing an exception when the data are stored in anything other than TTree?

  • :white_check_mark: CI Result SUCCESS (hash eb53f6f6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7151] (remote access info)

  • Restarting the job to validate the change proposed in ATLASG-2692: increase the number of unit test streams for AnalysisBase project. This MR is suitable for this check because it has "full-unit-tests" set

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Tools/PyUtils

    This merge request affects 2 files:

    • Tools/PyUtils/python/AthFileLite.py
    • Tools/PyUtils/python/MetaReader.py
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading