MuonTesterTree: Fix use-after-free error.

In MuonTesterTree, m_branches_to_init must be listed before m_branches. When m_branches is destroyed, the branches being deleted will try to remove themselves from m_branches_to_init. If these are in the opposite order, then m_branches_to_init will already have been destroyed, and we'll be accessing freed memory.

Fixes crash seen during genconf in some builds of MuonGeoModelTest.

Also rewrite Remove() to use remove_if.

This merge request affects 1 package:

• MuonSpectrometer/MuonValidation/MuonTesterTree

This merge request affects 2 files:

• MuonSpectrometer/MuonValidation/MuonTesterTree/MuonTesterTree/MuonTesterTree.h
• MuonSpectrometer/MuonValidation/MuonTesterTree/Root/MuonTesterTree.cxx

Adding @pscholer ,@stavrop ,@jojungge ,@rosati ,@kluit ,@apsallid as watchers

added MuonSpectrometer main review-pending-level-1 labels

CI Result SUCCESS (hash b7f8fd2c)

	Athena	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7299] (remote access info)

added review-approved label

removed review-pending-level-1 label

merged

mentioned in commit 90c93b49

mentioned in merge request !70302 (merged)