Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
atlas
athena
Merge requests
!70240
HGTD_GeoModel: Fix cppcheck warning.
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
HGTD_GeoModel: Fix cppcheck warning.
ssnyder/athena:cppcheck.HGTD_GeoModel-20240401
into
main
Overview
2
Commits
1
Pipelines
1
Changes
2
Merged
Scott Snyder
requested to merge
ssnyder/athena:cppcheck.HGTD_GeoModel-20240401
into
main
1 year ago
Overview
2
Commits
1
Pipelines
1
Changes
2
Expand
Pass object by const reference, not by value.
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
da050d7b
1 commit,
1 year ago
2 files
+
4
−
4
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
HighGranularityTimingDetector/HGTD_DetDescr/HGTD_GeoModel/HGTD_GeoModel/HGTD_DetectorFactory.h
+
2
−
2
Options
/*
Copyright (C) 2002-202
2
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-202
4
CERN for the benefit of the ATLAS collaboration
*/
#ifndef HGTD_GEOMODEL_HGTD_DETECTORFACTORY_H
@@ -95,7 +95,7 @@ private:
std
::
array
<
PositionsInQuadrant
,
4
>
prepareLayersFromQuadrants
(
unsigned
int
)
;
PositionsInQuadrant
prepareQuadrantsFromRows
(
int
layer
,
unsigned
int
maxRow
);
std
::
string
formModuleName
(
int
layer
,
int
quadrant
,
unsigned
int
maxrows
,
int
row
,
int
mod
,
ModulePosition
module
,
double
&
myx
,
double
&
myy
,
double
&
myrot
,
const
ModulePosition
&
module
,
double
&
myx
,
double
&
myy
,
double
&
myrot
,
int
&
phi
,
int
&
eta
)
;
// 3-ring layout
Loading