main-add_BCMPrime-AthenaConfiguration

Adding the possibility of incorporating BCMPrime, now geometry is defined in ITKLayouts repo.

added ITk label

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/AutoConfigFlags.py

Adding @gemmeren ,@maszyman ,@ssnyder as watchers

added Core analysis-review-required full-unit-tests main review-pending-level-1 labels

This may fail old geometry tags if they have BCMPrime enabled. I think we actually had a "legacy GeoModel" implementation that may be there, but I'm a bit out of the loop. Just a warning.

CI Result FAILURE (hash 298d6982)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7665] (remote access info)

One failure looks related to the failures seen in !70419 (merged). The others look to be prompted by this MR.

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/AutoConfigFlags.py

Adding @maszyman ,@gemmeren ,@ssnyder as watchers

CI Result SUCCESS (hash 298d6982)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7680] (remote access info)

added analysis-review-approved label and removed analysis-review-required label

added 1 commit

• 9d93ec64 - Update AutoConfigFlags.py

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/AutoConfigFlags.py

Adding @maszyman ,@ssnyder ,@gemmeren as watchers

CI Result SUCCESS (hash 9d93ec64)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7723] (remote access info)

I will merge this then... What I meant is that we use git so redundant comments on when a code change was added do not make sense (and will certainly not make sense in a year from now).

Before the detector was not added as some geometry tags had it enabled (this were pre-GMX times). Now it seems none of the production tags contain BCMPrime so we're fine enabling it and the comment is in principle not needed.

Ref.: ATLITKSW-234

The change is straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

mentioned in commit 6ae59119

merged