Skip to content
Snippets Groups Projects

TileMonitoring: Update beam elements monitoring for Tile TestBeam

Merged Siarhei Harkusha requested to merge harkusha/athena:24.0-tile-tb-beam-mon-update into 24.0
All threads resolved!

The algorithm to monitor beam elements for Tile TestBeam (TB) has been updated:

  • to add possibility to monitor impact point vs total energy registered in Tile TB setup;
  • to add possibility to monitor impact point vs maximum cell energy registered in Tile TB setup;
  • to add possibility to mask muon wall PMT in total energy registered by muon wall in Tile TB setup;
  • to add possibility to monitor TOF difference;
  • to add possibility to monitor cherenkov vs TOF;
  • to add possibility to monitor scalers.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just a few comments to address, otherwise looks good.

    Best, Thomas - L1

  • added 1 commit

    • 1b823685 - TileMonitoring: Fix cell energy monitoring variable and add the explanation to some change

    Compare with previous version

  • This merge request affects 1 package:

    • TileCalorimeter/TileMonitoring

    This merge request affects 3 files:

    • TileCalorimeter/TileMonitoring/python/TileTBBeamMonitorAlgorithm.py
    • TileCalorimeter/TileMonitoring/src/TileTBBeamMonitorAlgorithm.cxx
    • TileCalorimeter/TileMonitoring/src/TileTBBeamMonitorAlgorithm.h

    Adding @harkusha ,@iouri ,@solodkov ,@pavol as watchers

  • Siarhei Harkusha resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 1b823685)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7958] (remote access info)

  • All threads from previous L1 have been implemented and the CI is good. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Duc Ta mentioned in commit 1167c169

    mentioned in commit 1167c169

  • merged

  • Adam Edward Barton mentioned in merge request !70585 (merged)

    mentioned in merge request !70585 (merged)

  • Please register or sign in to reply
    Loading