HepMcParticleLink constructor syntax clean-up.

Avoid using 0 in combination with HepMcParticleLink::IS_EVENTNUM in constructor calls as this is not properly supported. It is more correct to directly use 0 with HepMcParticleLink::IS_POSITION to indicate that the link is to the first GenEvent in the McEventCollection.

(Relates to ATLASSIM-6999)

Tagging @pclark and @averbyts

This merge request affects 11 packages:

• ForwardDetectors/LUCID/LUCID_SimUtils/LUCID_SimEvent
• InnerDetector/InDetG4/BCM_G4_SD
• InnerDetector/InDetG4/BLM_G4_SD
• InnerDetector/InDetG4/PixelG4_SD
• InnerDetector/InDetG4/SCT_G4_SD
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonSimEvent
• Simulation/G4Sim/MCTruth
• Simulation/G4Utilities/G4Ancillary/G4AncillarySimEvent
• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Core/ISF_Services

Affected files list will not be printed in this case

Adding @lmijovic ,@apsallid ,@goetz ,@sroe ,@rosati ,@lshan ,@pscholer ,@jchapman ,@battagl ,@jojungge ,@stavrop ,@kluit ,@stsuno as watchers

added ForwardDetectors InnerDetector MuonSpectrometer Simulation main review-pending-level-1 labels

added Run2-FullSim-output-changed Run3-AF3-output-changed Run3-FullSim-output-changed Run4-FullSim-output-changed labels

CI Result FAILURE (hash 92d72238)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8029] (remote access info)

removed review-pending-level-1 label

marked this merge request as draft

added 10 commits

• 92d72238...c4cfacd2 - 8 commits from branch atlas:main
• 725c7e1b - Disable further default arguments in HepMcParticleLink constructors
• 0c3a8c97 - HepMcParticleLink constructor syntax clean-up.

Compare with previous version

removed Run2-FullSim-output-changed label

removed Run3-AF3-output-changed label

removed Run3-FullSim-output-changed label

removed Run4-FullSim-output-changed label

Jenkins please retry a build

This merge request affects 13 packages:

• ForwardDetectors/LUCID/LUCID_SimUtils/LUCID_SimEvent
• Generators/GeneratorObjects
• Generators/GeneratorObjectsTPCnv
• InnerDetector/InDetG4/BCM_G4_SD
• InnerDetector/InDetG4/BLM_G4_SD
• InnerDetector/InDetG4/PixelG4_SD
• InnerDetector/InDetG4/SCT_G4_SD
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonSimEvent
• Simulation/G4Sim/MCTruth
• Simulation/G4Utilities/G4Ancillary/G4AncillarySimEvent
• Simulation/ISF/ISF_Core/ISF_Event
• Simulation/ISF/ISF_Core/ISF_Services

Affected files list will not be printed in this case

Adding @stavrop ,@jojungge ,@battagl ,@kluit ,@jchapman ,@stsuno ,@gemmeren ,@rosati ,@pscholer ,@lmijovic ,@lshan ,@apsallid ,@sroe ,@goetz as watchers

added Generators label

CI integration tests for projects Athena are cancelled because of compilation error(s)

added Run2-FullSim-output-changed Run3-FullSim-output-changed Run4-FullSim-output-changed labels

CI Result FAILURE (hash 0c3a8c97)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 3, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8116] (remote access info)

added 3 commits

• d4bac6a7 - patches
• 54ee3ed3 - HepMcParticleLink constructor syntax clean-up.
• e81dc562 - ISFTruthIncident::updateHepMCTruthParticle should use...

Compare with previous version

Jenkins please retry a build