main-cppcheck-LArReadoutGeometry

Pass strings by const reference, not value. While there, tidied headers and avoided repeated sqrt(3)/2.

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization

This merge request affects 2 files:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/tools/FCAL_ChannelMap.cxx
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization/tools/LArReadoutGeometry/FCAL_ChannelMap.h

Adding @jbeirer ,@schaarsc ,@jchapman ,@tadej ,@zhangr as watchers

added Simulation main review-pending-level-1 labels

CI Result SUCCESS (hash 95caf9ee)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8094] (remote access info)

mentioned in commit 919ea0b1

merged