Updates to eta pattern filter and 1D Hough

This is the second part of our updates from HTTSim to make FPGATrackSim fully usable by the community. It includes all the material missing in !70389 (merged) Tagging @tbold @brosser @imaznas

added 1 commit

• 67528288 - try another less failed commit

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough

This merge request affects 4 files:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimEtaPatternFilterTool.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimEtaPatternFilterTool.h
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHough1DShiftTool.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHough1DShiftTool.h

added EFTracking Trigger main review-pending-level-1 labels

CI Result SUCCESS (hash 67528288)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8306] (remote access info)

A few style changes requested, otherwise looks ok to me.
Albert (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 3508a713 - small comments during review

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough

This merge request affects 4 files:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimEtaPatternFilterTool.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimEtaPatternFilterTool.h
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHough1DShiftTool.cxx
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHough1DShiftTool.h

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 3508a713)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8339] (remote access info)

The changes have been vetted already and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0407400b

mentioned in merge request !70838 (merged)