Skip to content
Snippets Groups Projects

eFEX Simulation: attempted fix for WSTot threshold bits in cases where part of the calculation overflows

Merged Will Buttinger requested to merge will/athena:24.0-efexWSTotFix into 24.0
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Will Buttinger resolved all threads

    resolved all threads

  • added 1 commit

    • 23fc48c3 - Update eFEXFPGA.cxx - remove commented code

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

    This merge request affects 2 files:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXFPGA.cxx
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/eFEXegAlgo.cxx

    Adding @thompson ,@will as watchers

  • :white_check_mark: CI Result SUCCESS (hash 23fc48c3)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8307] (remote access info)

  • Approved
    Albert (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Petar Bokan mentioned in commit 3f33a7c5

    mentioned in commit 3f33a7c5

  • merged

  • mentioned in merge request !70740 (merged)

  • Please register or sign in to reply
    Loading