CaloRecGPU: fixed clang warnings

• Inconsistent use of the class and struct keywords
• Local variables set but not used
• Unused function arguments
• Unused functions
• Missing override keywords

This merge request affects 1 package:

• Calorimeter/CaloRecGPU

This merge request affects 8 files:

• Calorimeter/CaloRecGPU/CaloRecGPU/EtaPhiMap.h
• Calorimeter/CaloRecGPU/CaloRecGPU/StandaloneDataIO.h
• Calorimeter/CaloRecGPU/src/BasicGPUClusterInfoCalculator.h
• Calorimeter/CaloRecGPU/src/BasicGPUToAthenaImporter.cxx
• Calorimeter/CaloRecGPU/src/CaloGPUClusterAndCellDataMonitor.cxx
• Calorimeter/CaloRecGPU/src/FPHelpers.h
• Calorimeter/CaloRecGPU/src/GPUKernelSizeOptimizerSvc.h
• Calorimeter/CaloRecGPU/src/GPUToAthenaImporterWithMoments.cxx

Adding @pavol ,@dossantn as watchers

added Calorimeter main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

108K in file Calorimeter/CaloRecGPU/src/CaloGPUClusterAndCellDataMonitor.cxx

Hi @dossantn, last night CaloRecGPU was compiled in clang nightlies for the first time. The compilation generated quite a few warnings. Here I attempted to fix them. Could you please check that my fixes make sense?

I have not compiled my changes against clang17 nightly (we don't seem to have one installed on CVMFS), but I compiled them against gcc13 nightly.

CI Result SUCCESS (hash 9310c156)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8310] (remote access info)

resolved all threads

added review-user-action-required label and removed review-pending-level-1 label

added 44 commits

• 9310c156...3130f01b - 43 commits from branch atlas:main
• 912b3090 - CaloRecGPU: fixed clang warnings

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Calorimeter/CaloRecGPU

This merge request affects 8 files:

• Calorimeter/CaloRecGPU/CaloRecGPU/EtaPhiMap.h
• Calorimeter/CaloRecGPU/CaloRecGPU/StandaloneDataIO.h
• Calorimeter/CaloRecGPU/src/BasicGPUClusterInfoCalculator.h
• Calorimeter/CaloRecGPU/src/BasicGPUToAthenaImporter.cxx
• Calorimeter/CaloRecGPU/src/CaloGPUClusterAndCellDataMonitor.cxx
• Calorimeter/CaloRecGPU/src/FPHelpers.h
• Calorimeter/CaloRecGPU/src/GPUKernelSizeOptimizerSvc.h
• Calorimeter/CaloRecGPU/src/GPUToAthenaImporterWithMoments.cxx

Adding @dossantn ,@pavol as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

108K in file Calorimeter/CaloRecGPU/src/CaloGPUClusterAndCellDataMonitor.cxx

Hi @dossantn, thanks for the feedback! Actually, we now have the latest clang17 nightly properly installed on CVMFS, so I was able to compile my changes against it and catch a couple of warnings that were not fixed on the first attempt. Hopefully, we are good now.

CI Result SUCCESS (hash 912b3090)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8347] (remote access info)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 18a391e2