Rewrite of KalmanMET in L1Topo Simulation

KFMET was never fully commissioned for legacy L1Topo in Run2 and the desired prescription of this algorithm was slightly changed for Run3 / Phase1 L1Topo. Hence, the firmware algorithm and its simulation counterpart were essentially fully rewritten. The latter rewrite is contained in this MR. Following the deployment of Ph1Topo FW v10.0.1 a local Athena build including the changes in this MR was used to asses the FW/Sim agreement using 100k events from run 473915. Firmware and simulation results are found to be in full agreement with between 20-40% accepted events (depending on exact KFMET threshold) in the sample used (roughly comparable to other MET triggers with similar thresholds)

This merge request affects 3 packages:

• Trigger/TrigT1/L1Topo/L1TopoAlgorithms
• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/L1Topo/L1TopoSimulationUtils

Affected files list will not be printed in this case

Adding @asonay ,@iriu ,@stelzer ,@oliveirg ,@paulama ,@jmharris ,@orlando ,@cmorenom ,@jchapman as watchers

added 24.0 JetEtmiss Trigger review-pending-level-1 labels

CI Result FAILURE (hash f2837929)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
DetCommon: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8354] (remote access info)

added 2 commits

• d3360047 - silencing compiler warning
• 0dd87926 - updating ref counts following fix of global sign of jXE in L1Topo

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 5 packages:

• Trigger/TrigT1/L1Topo/L1TopoAlgorithms
• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/L1Topo/L1TopoSimulationUtils
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @jchapman ,@stelzer ,@salderwe ,@okumura ,@orlando ,@cmorenom ,@asonay ,@oliveirg ,@jmharris ,@iriu ,@vmartin ,@martindl ,@paulama as watchers

added changes-trigger-counts label

resolved all threads

WARNING: big files (>100K) are found in the changeset

576K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

340K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

CI Result SUCCESS (hash 0dd87926)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8359] (remote access info)

Only two commented lines of code, should they be kept or did they slipped cleanup?

Otherwise approving.

Cheers, Philipp (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• a6147dc5 - minor cleanup

Compare with previous version

This merge request affects 5 packages:

• Trigger/TrigT1/L1Topo/L1TopoAlgorithms
• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/L1Topo/L1TopoSimulationUtils
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @paulama ,@oliveirg ,@orlando ,@vmartin ,@stelzer ,@cmorenom ,@asonay ,@jchapman ,@martindl ,@okumura ,@jmharris ,@iriu ,@salderwe as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

WARNING: big files (>100K) are found in the changeset

340K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

576K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

CI Result SUCCESS (hash a6147dc5)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8389] (remote access info)

Looks good to me, approving.

Cheers, Philipp

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

merged

mentioned in commit 98316550

mentioned in merge request !70805 (merged)