Fix ESD bug in assigning Dead Material hits

In ATLASSIM-6880 and ATLASSIM-7168 it was reported that in MC23 ESD samples there are several job failures that are due to unassigned dead material hits. This only affects ESDs with calibration hits which is why we haven't seen this in general MC23 production.

I have tracked this to two primary sources;

1. hits which are just inside the zMaxBarrel (3164mm in the db) which should be assigned to inactive matter between EMB and scintillator. A margin of 10mm has been added to make these hits assigned correctly.
2. hits with very low energy which have little impact. For hits with energy less than 1 MeV I have downgraded the ERROR to a WARNING.

Tests (https://bigpanda.cern.ch/task/38265506/) show that these appear to solve the issues. This should make no change to anything other than ESD samples with Calibration Hits. Therefore it would be nice to include this in the MC23e tag if possible. (Whether MC23a/d need to be fixed needs to be discussed).

added 24.0 Simulation labels

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 1 file:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.cxx

Adding @pavol as watcher

added LAr review-pending-level-1 labels

CI Result SUCCESS (hash aee17d68)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8381] (remote access info)

Hi, there are as of now still two unresolved threads. Returning this to review-user-action-required .

Cheers, Philipp (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 50f7a1f7 - Clean up messages and make margin a constant

Compare with previous version

This merge request affects 1 package:

• LArCalorimeter/LArG4/LArG4Barrel

This merge request affects 2 files:

• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.cxx
• LArCalorimeter/LArG4/LArG4Barrel/src/LArBarrelGeometry.h

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 50f7a1f7)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8407] (remote access info)

Changes look fine, CI is good and all threads have been resolved. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

merged

mentioned in commit 36c305df

mentioned in merge request !70805 (merged)