Simplification of ISF::TruthSvc

After !66930 (merged), existing GenParticle and GenVertex objects are no longer removed/replaced during simulation. This allows for a considerable simplification to the TruthSvc code. In local tests these changes made no difference to the simulation output (even with quasi-stable particle simulation enabled).

Tagging @mduehrss, @pclark, @averbyts, @mbandier, @schaarsc

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Services

This merge request affects 3 files:

• Simulation/ISF/ISF_Core/ISF_Services/src/TruthSvc.cxx
• Simulation/ISF/ISF_Core/ISF_Services/src/TruthSvc.h
• Simulation/ISF/ISF_Core/ISF_Services/test/TruthSvc_test.cxx

Adding @jchapman ,@lmijovic as watchers

added Simulation main review-pending-level-1 labels

added 1 commit

• 10a94a3a - Simplification of TruthSvc.cxx

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Services

This merge request affects 3 files:

• Simulation/ISF/ISF_Core/ISF_Services/src/TruthSvc.cxx
• Simulation/ISF/ISF_Core/ISF_Services/src/TruthSvc.h
• Simulation/ISF/ISF_Core/ISF_Services/test/TruthSvc_test.cxx

Adding @jchapman ,@lmijovic as watchers

CI Result SUCCESS (hash ee70a7ff)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8609] (remote access info)

CI Result SUCCESS (hash 10a94a3a)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8611] (remote access info)

Hi, looks good to me (L1 shifter). Passing it on for a second check to L2. Cheers Andreas

removed review-pending-level-1 label

added review-pending-level-2 label

Looks good, approving - L2

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 58d058b1

mentioned in merge request !70923 (merged)